PULL_REQUEST_TEMPLATE.md: clarify demo credentials requirements #1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodiscc
added
documentation
|
What is our stance on login but no demo credentials linked, i.e the user needs to create an account? example: Bitcart has authentication but no login details are provided. |
|
As long as it has a create account page + credentials are properly registered, I am fine with that. I would prefer an easy to access delete account button as a bonus too, but I digress, I leave the floor for other collaborators to contribute their thoughts 👍🏻 P.S. We can also ask the maintainer if they could make demo credentials / link them |
It's not ideal but better than nothing, I am fine with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the very confusing review process in #1028, clarify what is expected in the
demo_urlfield.