Add transaction exchange #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows peers to exchange transactions in the memory pool efficiently.
It's currently triggered once with each peer upon connection, because all other transactions should in theory be propagated properly. It makes sense to think about implementing some regular resynchronization with each peer, as the mechanism really doesn't need much.
It's described in #107, which can be used for a real specification.
In order to avoid filling the queue for outgoing messages on each peer by sending each transaction one by one on request, we should implement batch as explained in #110.
However, a more complete fix is to implement a proper separation between being informed of unknown transactions by a peer and requesting them. The IDs should basically go into a pending list and we should download batch after batch from peers where they are available, as described in #105.