Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

Commit

Permalink
Updating Facade Alias (#22)
Browse files Browse the repository at this point in the history 
Resolving #18
  • Loading branch information
@awjudd
awjudd authored Dec 13, 2016
1 parent 2f3ac81 commit c3c856e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ In your `config/app.php` add `'Awjudd\FeedReader\FeedReaderServiceProvider'` to
'App' => 'Illuminate\Support\Facades\App',
'Artisan' => 'Illuminate\Support\Facades\Artisan',
...
'FeedReader' => 'Awjudd\FeedReader\Facades',
'FeedReader' => 'Awjudd\FeedReader\Facades\FeedReader',

This comment has been minimized.

Sign in to view

Copy link
@ebisbe

ebisbe Dec 16, 2016

I don't know if you have tested this but it's not working on my app. I've just updated my composer to found that your facade is crashing.

I have ended with

'FeedReader' => Awjudd\FeedReader\Facade::class,

This comment has been minimized.

Sign in to view

Copy link
@awjudd

awjudd Dec 16, 2016

Author Owner

I'll investigate shortly.

This comment has been minimized.

Sign in to view

Copy link
@awjudd

awjudd Dec 19, 2016

Author Owner

@ebisbe What error are you getting? I just tried locally in a fresh install of Laravel and it works just fine.

This comment has been minimized.

Sign in to view

Copy link
@ebisbe

ebisbe Dec 19, 2016

I have that error.

ErrorException in AliasLoader.php line 66: Class 'Awjudd\FeedReader\Facades\FeedReader' not found

I've just updated my composer to check I was at last version. Current version is "version": "1.3.2",

This comment has been minimized.

Sign in to view

Copy link
@awjudd

awjudd Dec 19, 2016

Author Owner

@ebisbe You have it pointing to the wrong facade. Your app.config should be updated with the text you have listed above, but it looks like right now you are pointing to Awjudd\FeedReader\Facades\FeedReader

This comment has been minimized.

Sign in to view

Copy link
@ebisbe

ebisbe Dec 19, 2016

I don't understand what you are saying. Can you write down the things you are saying instead of referring to them? If I update my code with your line +42 from the README.md commit , then the app is not working.

This comment has been minimized.

Sign in to view

Copy link
@awjudd

awjudd Dec 19, 2016

Author Owner

The following error message says that you are referring to the wrong class:

ErrorException in AliasLoader.php line 66: Class 'Awjudd\FeedReader\Facades\FeedReader' not found

Instead of using this, you will need to use in your app.php:

'FeedReader' => Awjudd\FeedReader\Facade::class,

My guess is you have:

'FeedReader' => Awjudd\FeedReader\Facades\FeedReader::class,
),
```

Expand Down Expand Up @@ -75,4 +75,4 @@ Feed Reader is free software distributed under the terms of the MIT license

## Additional Information

Any issues, please [report here](https://github.com/awjudd/l4-feed-reader/issues)
Any issues, please [report here](https://github.com/awjudd/l4-feed-reader/issues)

0 comments on commit c3c856e

Please sign in to comment.