[fix] Not following redirects (https://youtu.be/v1wfQPGXhVA) #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[fix] Not getting og:description for https://www.youtube.com/watch?v=v1wfQPGXhVA awkward#15 awkward#16
[feature] being able to set a custom userAgent [fix] remove extra whitespace awkward#18
renssies
suggested changes
Jul 9, 2020
| @@ -173,6 +181,14 @@ public class OcarinaManager: NSObject { | |||
|
|
|||
| extension OcarinaManager: URLSessionDataDelegate { | |||
|
|
|||
| public func urlSession(_ session: URLSession, | |||
There was a problem hiding this comment.
Small style thing here: Could you make the function name and parameters all on one line, like all other delegate methods :)
Co-authored-by: Rens Verhoeven <[email protected]>
Co-authored-by: Rens Verhoeven <[email protected]>
[fix] urlSession delegate being on 1 line
|
I committed your suggestions. Thanks! |
renssies
approved these changes
Jul 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[fix] Not getting og:description for https://www.youtube.com/watch?v=v1wfQPGXhVA
[fix] Timeout when fetching DHL tracking url
#15
#16
#18