Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added user pool client codegen #14016

Merged
merged 5 commits into from
Nov 27, 2024
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ export interface AuthSynthesizerOptions {
guestLogin?: boolean;
mfaConfig?: UserPoolMfaType;
totpConfig?: SoftwareTokenMfaConfigType;
userPoolClient?: UserPoolClientType;
}

export const DEFAULT_PASSWORD_SETTINGS: PasswordPolicyType = {
Expand Down Expand Up @@ -247,6 +248,7 @@ export const getAuthDefinition = ({
referenceAuth,
mfaConfig,
totpConfig,
userPoolClient,
}: AuthSynthesizerOptions): AuthDefinition => {
const mappedUserAttributeName = {
address: 'address',
Expand Down Expand Up @@ -363,5 +365,6 @@ export const getAuthDefinition = ({
readAttributes: webClient?.ReadAttributes,
writeAttributes: webClient?.WriteAttributes,
referenceAuth,
userPoolClient,
};
};
3 changes: 2 additions & 1 deletion packages/amplify-gen2-codegen/src/auth/source_builder.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import ts, { PropertyAssignment } from 'typescript';
import assert from 'node:assert';
import { PasswordPolicyType } from '@aws-sdk/client-cognito-identity-provider';
import { PasswordPolicyType, UserPoolClientType } from '@aws-sdk/client-cognito-identity-provider';
import { renderResourceTsFile } from '../resource/resource';
import { createTriggersProperty, Lambda } from '../function/lambda';

Expand Down Expand Up @@ -151,6 +151,7 @@ export interface AuthDefinition {
readAttributes?: string[];
writeAttributes?: string[];
referenceAuth?: ReferenceAuth;
userPoolClient?: UserPoolClientType;
}

const factory = ts.factory;
Expand Down
138 changes: 137 additions & 1 deletion packages/amplify-gen2-codegen/src/backend/synthesizer.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,143 @@ describe('BackendRenderer', () => {
},
});
const output = printNodeArray(rendered);
assert(output.includes('applyRemovalPolicy'));
assert(output.includes('s3Bucket.applyRemovalPolicy'));
});
});
describe('UserPoolClient Configuration using render()', () => {
it('renders complete user pool client configuration', () => {
const renderer = new BackendSynthesizer();
const rendered = renderer.render({
auth: {
importFrom: './auth/resource.ts',
userPoolClient: {
UserPoolId: 'us-west-2_aaaaaaaaa',
ClientName: 'MyApp',
ClientId: '38fjsnc484p94kpqsnet7mpld0',
ClientSecret: 'CLIENT_SECRET',
RefreshTokenValidity: 30,
AccessTokenValidity: 79,
ReadAttributes: [
'address',
'birthdate',
'custom:CustomAttr1',
'custom:CustomAttr2',
'email',
'email_verified',
'family_name',
'gender',
'given_name',
'locale',
'middle_name',
'name',
'nickname',
'phone_number',
'phone_number_verified',
'picture',
'preferred_username',
'profile',
'updated_at',
'website',
'zoneinfo',
],
WriteAttributes: [
'address',
'birthdate',
'custom:CustomAttr1',
'custom:CustomAttr2',
'email',
'family_name',
'gender',
'given_name',
'locale',
'middle_name',
'name',
'nickname',
'phone_number',
'picture',
'preferred_username',
'profile',
'updated_at',
'website',
'zoneinfo',
],
ExplicitAuthFlows: ['ADMIN_NO_SRP_AUTH', 'USER_PASSWORD_AUTH'],
AllowedOAuthFlowsUserPoolClient: true,
AllowedOAuthFlows: ['code', 'implicit'],
AllowedOAuthScopes: [
'phone',
'email',
'openid',
'profile',
'aws.cognito.signin.user.admin',
'custom:CustomScope1',
'custom:CustomScope2',
],
CallbackURLs: ['XXXXXXXXXXXXXXXXXX', 'XXXXXXXXXXXXXXXXXXXXXX'],
LogoutURLs: ['XXXXXXXXXXXXXXXXXX', 'XXXXXXXXXXXXXXXXXXXXXX'],
DefaultRedirectURI: 'XXXXXXXXXXXXXXXXXX',
SupportedIdentityProviders: ['COGNITO'],
AuthSessionValidity: 3,
EnableTokenRevocation: true,
EnablePropagateAdditionalUserContextData: true,
TokenValidityUnits: {
RefreshToken: 'hours',
AccessToken: 'minutes',
IdToken: 'minutes',
},
},
},
});

const output = printNodeArray(rendered);

// Basic configuration
expect(output).toContain('"us-west-2_aaaaaaaaa"');
expect(output).toContain('userPoolClientName: "MyApp"');

// Token validity settings
expect(output).toContain('refreshTokenValidity: Duration.hours(30),');
expect(output).toContain('accessTokenValidity: Duration.minutes(79)');

// Attributes
expect(output).toContain('readAttributes: new ClientAttributes().withStandardAttributes');
expect(output).toContain('writeAttributes: new ClientAttributes().withStandardAttributes');
expect(output).toContain('custom:CustomAttr1');

// OAuth configuration
expect(output).toContain('flows: { authorizationCodeGrant: true, implicitCodeGrant: true, clientCredentials: false }');

// OAuth scopes
expect(output).toContain('OAuthScope.PHONE');
expect(output).toContain('OAuthScope.EMAIL');
expect(output).toContain('OAuthScope.OPENID');

// URLs
expect(output).toContain('callbackUrls');
expect(output).toContain('logoutUrls');
expect(output).toContain('defaultRedirectUri');

// Auth flows
expect(output).toContain('authFlows: { adminUserPassword: false, custom: false, userPassword: false, userSrp: false }');

// Additional settings
expect(output).toContain('supportedIdentityProviders');
expect(output).toContain('authSessionValidity: Duration.minutes(3)');
expect(output).toContain('enableTokenRevocation: true');
expect(output).toContain('enablePropagateAdditionalUserContextData: true');
});
it('renders userpool and identitypool deletion policy', () => {
const renderer = new BackendSynthesizer();
const rendered = renderer.render({
auth: {
importFrom: 'auth/resource.ts',
identityPoolName: 'testIdentityPool',
userPoolOverrides: {},
},
});
const output = printNodeArray(rendered);
assert(output.includes('cfnUserPool.applyRemovalPolicy'));
assert(output.includes('cfnIdentityPool.applyRemovalPolicy'));
});
});
});
Loading
Loading