chore(smithy,auth): Dart 3.3.0 Beta Analysis Errors (#4354)

aws-amplify · Jan 17, 2024 · e92693b · e92693b
1 parent f60e65b
commit e92693b
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 4 deletions.
diff --git a/packages/auth/amplify_auth_cognito_dart/lib/src/asf/asf_device_info_collector.windows.dart b/packages/auth/amplify_auth_cognito_dart/lib/src/asf/asf_device_info_collector.windows.dart
@@ -102,6 +102,8 @@ final class ASFDeviceInfoWindows extends ASFDeviceInfoPlatform {
       final langCodepageArr = lpTranslate.value;
       final n = lenTranslate.value / sizeOf<_LANGANDCODEPAGE>();
       final langCodepages = [
+        // TODO(equartey): `.elementAt(i)` is depreciated in Dart 3.3.0. Use `(langCodepageArr + i).ref` when min Dart version is 3.3.0 or higher
+        // ignore: deprecated_member_use
         for (var i = 0; i < n; i++) langCodepageArr.elementAt(i).ref,
       ];
       for (final _LANGANDCODEPAGE(:wLanguage, :wCodepage) in langCodepages) {

diff --git a/packages/smithy/smithy/lib/src/ast/shapes/collection_shape.dart b/packages/smithy/smithy/lib/src/ast/shapes/collection_shape.dart
@@ -23,7 +23,7 @@ class NamedMembersMap extends DelegatingMap<String, MemberShape> {
   NamedMembersMap(super.members);
 
   @override
-  bool operator ==(Object? other) =>
+  bool operator ==(Object other) =>
       identical(this, other) ||
       other is NamedMembersMap &&
           const MapEquality<String, MemberShape>().equals(this, other);

diff --git a/packages/smithy/smithy/lib/src/ast/shapes/shape_map.dart b/packages/smithy/smithy/lib/src/ast/shapes/shape_map.dart
@@ -12,7 +12,7 @@ class ShapeMap extends DelegatingMap<ShapeId, Shape> {
   ShapeMap(super.shapes);
 
   @override
-  bool operator ==(Object? other) =>
+  bool operator ==(Object other) =>
       identical(this, other) ||
       other is ShapeMap &&
           const MapEquality<ShapeId, Shape>().equals(this, other);

diff --git a/packages/smithy/smithy/lib/src/ast/shapes/trait_map.dart b/packages/smithy/smithy/lib/src/ast/shapes/trait_map.dart
@@ -27,7 +27,7 @@ class TraitMap extends DelegatingMap<ShapeId, Trait> {
   T expectTrait<T extends Trait>() => values.firstWhere((t) => t is T) as T;
 
   @override
-  bool operator ==(Object? other) =>
+  bool operator ==(Object other) =>
       identical(this, other) ||
       other is TraitMap &&
           const MapEquality<ShapeId, Trait>().equals(this, other);

diff --git a/packages/smithy/smithy_codegen/lib/src/util/config_parameter.dart b/packages/smithy/smithy_codegen/lib/src/util/config_parameter.dart
@@ -34,7 +34,7 @@ class ParameterLocation {
       ParameterLocation._(val & other.val);
 
   @override
-  bool operator ==(Object? other) =>
+  bool operator ==(Object other) =>
       identical(this, other) || other is ParameterLocation && val == other.val;
 
   @override