fix(datastore): observequery local only collect

[atierian]

Issue #

• DataStore observeQuery is slow unless AWSAPIPlugin is added #3100

Description

DataStore.observeQuery(...) has some internal logic to batch snapshots received based on total count or time elapsed while syncing. This logic is applied when DataStore thinks it is hasn't yet completed syncing.

When DataStore is in local only mode (i.e. when AWSAPIPlugin isn't being used), it is never "completed syncing", leading to the same throttling logic.

This change ensures that the throttling / collect logic is not applied when DataStore is in local only mode.

General Checklist

• Added new tests to cover change, if needed
• Build succeeds with all target using Swift Package Manager
• All unit tests pass
• All integration tests pass
• Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
• Documentation update for the change if required
• PR title conforms to conventional commit style
• New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
• If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[codecov-commenter]

Codecov Report

Merging #3214 (0c60997) into main (659fdf9) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main    #3214      +/-   ##
==========================================
+ Coverage   64.74%   64.76%   +0.02%     
==========================================
  Files        1090     1090              
  Lines       36988    36998      +10     
==========================================
+ Hits        23948    23962      +14     
+ Misses      13040    13036       -4     

Flag	Coverage Δ
API_plugin_unit_test	66.52% <ø> (ø)
AWSPluginsCore	69.55% <ø> (ø)
Amplify	47.84% <ø> (-0.02%)	⬇️
Analytics_plugin_unit_test	86.39% <ø> (ø)
Auth_plugin_unit_test	75.23% <ø> (+0.07%)	⬆️
CoreMLPredictions_plugin_unit_test	59.44% <ø> (ø)
DataStore_plugin_unit_test	81.14% <100.00%> (-0.02%)	⬇️
Geo_plugin_unit_test	54.06% <ø> (ø)
Logging_plugin_unit_test	62.77% <ø> (ø)
Predictions_plugin_unit_test	35.17% <ø> (ø)
PushNotifications_plugin_unit_test	69.69% <ø> (ø)
Storage_plugin_unit_test	54.10% <ø> (ø)
unit_tests	64.76% <100.00%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
...Plugin/Storage/StorageEngine+SyncRequirement.swift	80.18% <100.00%> (+0.38%)	⬆️
...gin/Subscribe/DataStoreObserveQueryOperation.swift	83.17% <100.00%> (+0.65%)	⬆️

... and 10 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[lawmicha]

perhaps we can open up an issue on the other DataStore repos to let them verify if they have the same behavior, and if so they can do the similar change here