-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Auth): Adding network preferences #3379
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3379 +/- ##
==========================================
- Coverage 68.17% 68.13% -0.04%
==========================================
Files 1077 1078 +1
Lines 35973 35994 +21
==========================================
+ Hits 24523 24525 +2
- Misses 11450 11469 +19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
questions regarding the types in AWSCognitoNetworkPreferences. Not sure if there's an opportunity here to change some of the types of those properties considering we are adding back something that was taken out by accident.
AmplifyPlugins/Auth/Sources/AWSCognitoAuthPlugin/Models/AWSCognitoNetworkPreferences.swift
Show resolved
Hide resolved
AmplifyPlugins/Auth/Sources/AWSCognitoAuthPlugin/Models/AWSCognitoNetworkPreferences.swift
Outdated
Show resolved
Hide resolved
AmplifyPlugins/Auth/Sources/AWSCognitoAuthPlugin/AWSCognitoAuthPlugin+Configure.swift
Show resolved
Hide resolved
AmplifyPlugins/Auth/Sources/AWSCognitoAuthPlugin/Models/AWSCognitoNetworkPreferences.swift
Outdated
Show resolved
Hide resolved
…nitoNetworkPreferences.swift Co-authored-by: Sebastian Villena <[email protected]>
Issue #
#3004
Description
This PR aims to add network preferences (
AWSCognitoNetworkPreferences
) back to the Auth plugin which were accidentally removed while release Amplify V2.This preference helps control
Example configuration:
NOTE: Resource time out is only applicable to HostedUI ATM, because the underlying Swift SDK does not support resource timeouts. Hence
timeoutIntervalForResource
has been made an optional.General Checklist
Given When Then
inline code documentation and are named accordinglytestThing_condition_expectation()
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.