Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Auth): Rename resendConfirmationCode API for User Attributes to sendVerificationCode #3384

Merged
merged 5 commits into from
Dec 7, 2023

Conversation

harsh62
Copy link
Member

@harsh62 harsh62 commented Nov 27, 2023

Description

To make API behaviour consistent across Amplify Libraries. Auth.resendConfirmationCode is being renamed to Auth.sendVerificationCode. Changes:

  • Deprecated Auth.resendConfirmationCode
  • Added new API Auth.sendVerificationCode which is the same as the API being deprecated
  • Updated unit and integration tests.

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@harsh62 harsh62 changed the title feat(Auth): Rename resendConfirmationCode API for User Attributes to … feat(Auth): Rename resendConfirmationCode API for User Attributes to sendVerificationCode Nov 27, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2023

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (b9b5918) 68.17% compared to head (a1b6e3f) 67.88%.

Files Patch % Lines
...est/AuthAttributeSendVerificationCodeRequest.swift 0.00% 5 Missing ⚠️
...AWSAuthSendUserAttributeVerificationCodeTask.swift 84.84% 5 Missing ⚠️
...fy/Categories/Auth/AuthCategory+UserBehavior.swift 0.00% 3 Missing ⚠️
...ntBehavior/AWSCognitoAuthPlugin+UserBehavior.swift 90.90% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3384      +/-   ##
==========================================
- Coverage   68.17%   67.88%   -0.29%     
==========================================
  Files        1077     1080       +3     
  Lines       35973    36025      +52     
==========================================
- Hits        24523    24454      -69     
- Misses      11450    11571     +121     
Flag Coverage Δ
API_plugin_unit_test 67.07% <ø> (ø)
AWSPluginsCore 64.59% <ø> (ø)
Amplify 47.75% <0.00%> (-0.06%) ⬇️
Analytics_plugin_unit_test 81.16% <ø> (ø)
Auth_plugin_unit_test 79.07% <86.95%> (-0.39%) ⬇️
CoreMLPredictions_plugin_unit_test 59.44% <ø> (ø)
DataStore_plugin_unit_test 79.97% <ø> (-1.00%) ⬇️
Geo_plugin_unit_test 70.75% <ø> (ø)
Logging_plugin_unit_test 63.09% <ø> (ø)
Predictions_plugin_unit_test 37.29% <ø> (ø)
PushNotifications_plugin_unit_test 87.03% <ø> (ø)
Storage_plugin_unit_test 78.00% <ø> (ø)
unit_tests 67.88% <74.07%> (-0.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@harsh62 harsh62 marked this pull request as ready for review November 27, 2023 18:50
@harsh62 harsh62 requested a review from a team as a code owner November 27, 2023 18:50
@harsh62
Copy link
Member Author

harsh62 commented Nov 29, 2023

@lawmicha Updated the deprecation message.

@5d 5d merged commit 15c514e into main Dec 7, 2023
77 checks passed
@5d 5d deleted the rename-resend-user-attribute-api branch December 7, 2023 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants