Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(storage): fix copy_configuration script for stress test #3639

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

lawmicha
Copy link
Contributor

@lawmicha lawmicha commented Apr 25, 2024

Issue #

Description

For the stress test workflow, we have not yet updated this to run against amplify_outputs config. However the test exits after it copies the configuration file. The script is written in a way that it looks like either only AWSAmplifyStressTests-amplifyconfiguration.json exists or AWSS3StoragePluginTests-amplifyconfiguration.json but not both. One easy fix here is to touch the outputs file when running in the context of the stress test (when AWSAmplifyStressTests-amplifyconfiguration.json exists)

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lawmicha lawmicha requested a review from a team as a code owner April 25, 2024 22:59
@lawmicha lawmicha temporarily deployed to IntegrationTest April 25, 2024 22:59 — with GitHub Actions Inactive
@lawmicha lawmicha temporarily deployed to IntegrationTest April 25, 2024 23:00 — with GitHub Actions Inactive
@lawmicha lawmicha temporarily deployed to IntegrationTest April 25, 2024 23:00 — with GitHub Actions Inactive
@lawmicha lawmicha temporarily deployed to IntegrationTest April 25, 2024 23:00 — with GitHub Actions Inactive
@lawmicha lawmicha temporarily deployed to IntegrationTest April 25, 2024 23:00 — with GitHub Actions Inactive
@lawmicha lawmicha temporarily deployed to IntegrationTest April 25, 2024 23:00 — with GitHub Actions Inactive
@lawmicha
Copy link
Contributor Author

lawmicha commented Apr 25, 2024

@lawmicha lawmicha merged commit 038733f into main Apr 25, 2024
84 of 93 checks passed
@lawmicha lawmicha deleted the test.storage-gen2-stres branch April 25, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants