Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(Storage): Adding unit and integration tests #3829

Merged
merged 3 commits into from
Aug 27, 2024

Conversation

sebaland
Copy link
Contributor

@sebaland sebaland commented Aug 22, 2024

Description

This PR adds both unit and integration tests for the multibucket support.

⚠️ Note: As part of this work I noticed we were not populating StorageListResult.Item.size when using Gen2's list API, so I've fixed that as well.

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Sorry, something went wrong.

Unverified

This user has not yet uploaded their public signing key.
@sebaland sebaland requested a review from a team as a code owner August 22, 2024 20:50
@sebaland sebaland changed the title Ruisebas/multibucket tests test(Storage): Adding unit and integration tests Aug 22, 2024
Copy link
Contributor

API Breakage Report

✅ No Public API Breaking Change detected

@github-actions github-actions bot requested a review from a team as a code owner August 22, 2024 20:58
@sebaland sebaland merged commit bc1758d into feature/multibucket-storage Aug 27, 2024
@sebaland sebaland deleted the ruisebas/multibucket_tests branch August 27, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants