fix: address PR feedback

aws-amplify · Feb 17, 2025 · b13c415 · b13c415
1 parent 2706ceb
commit b13c415
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 11 deletions.
diff --git a/...es/react-native/src/Authenticator/Defaults/SelectMfaType/__tests__/SelectMfaType.spec.tsx b/...es/react-native/src/Authenticator/Defaults/SelectMfaType/__tests__/SelectMfaType.spec.tsx
@@ -85,6 +85,6 @@ describe('SelectMfaType', () => {
     const { queryByText } = render(<SelectMfaType {...props} isPending />);
 
     expect(queryByText(getConfirmingText())).toBeDefined();
-    expect(queryByText(getConfirmText())).toBe(null);
+    expect(queryByText(getConfirmText())).toBeNull();
   });
 });
diff --git a/packages/react-native/src/Authenticator/Defaults/SetupEmail/__tests__/SetupEmail.spec.tsx b/packages/react-native/src/Authenticator/Defaults/SetupEmail/__tests__/SetupEmail.spec.tsx
@@ -73,6 +73,6 @@ describe('SetupEmail', () => {
     const { queryByText } = render(<SetupEmail {...props} isPending />);
 
     expect(queryByText(getConfirmingText())).toBeDefined();
-    expect(queryByText(getConfirmText())).toBe(null);
+    expect(queryByText(getConfirmText())).toBeNull();
   });
 });
diff --git a/packages/react-native/src/Authenticator/common/DefaultFormFields/DefaultFormFields.tsx b/packages/react-native/src/Authenticator/common/DefaultFormFields/DefaultFormFields.tsx
@@ -16,10 +16,10 @@ const DefaultFormFields = ({
   fieldLabelStyle,
   isPending = false,
   validationErrors,
-  fields,
+  fields = [],
   style,
 }: DefaultFormFieldsProps): React.JSX.Element => {
-  const formFields = (fields ?? []).map((field) => {
+  const formFields = fields.map((field) => {
     const errors = validationErrors
       ? getErrors(validationErrors?.[field.name])
       : [];

diff --git a/packages/react-native/src/Authenticator/hooks/useFieldValues/__tests__/utils.spec.ts b/packages/react-native/src/Authenticator/hooks/useFieldValues/__tests__/utils.spec.ts
@@ -198,7 +198,6 @@ describe('getSanitizedFields', () => {
       'Each field must have a name; field has been ignored.'
     );
 
-    expect(output).toHaveLength(1);
     expect(output).toStrictEqual([validField]);
   });
 
@@ -214,10 +213,9 @@ describe('getSanitizedFields', () => {
 
     expect(warnSpy).toHaveBeenCalledTimes(1);
     expect(warnSpy).toHaveBeenCalledWith(
-      'Each field name must be unique; field with duplicate name of email has been ignored.'
+      'Each field name must be unique; field with duplicate name of "email" has been ignored.'
     );
 
-    expect(output).toHaveLength(1);
     expect(output).toStrictEqual([validField]);
   });
 
@@ -237,10 +235,9 @@ describe('getSanitizedFields', () => {
 
     expect(warnSpy).toHaveBeenCalledTimes(1);
     expect(warnSpy).toHaveBeenCalledWith(
-      'Each radio field must have at least one option available for selection; field without radioOptions mfa_type has been ignored.'
+      'Each radio field must have at least one option available for selection; field of name "mfa_type" without radioOptions has been ignored.'
     );
 
-    expect(output).toHaveLength(1);
     expect(output).toStrictEqual([validField]);
   });
 });

diff --git a/packages/react-native/src/Authenticator/hooks/useFieldValues/utils.ts b/packages/react-native/src/Authenticator/hooks/useFieldValues/utils.ts
@@ -87,14 +87,14 @@ export const getSanitizedFields = (fields: TypedField[]): TypedField[] => {
 
     if (names[name]) {
       logger.warn(
-        `Each field name must be unique; field with duplicate name of ${name} has been ignored.`
+        `Each field name must be unique; field with duplicate name of "${name}" has been ignored.`
       );
       return false;
     }
 
     if (isRadioFieldOptions(field) && !field.radioOptions?.length) {
       logger.warn(
-        `Each radio field must have at least one option available for selection; field without radioOptions ${name} has been ignored.`
+        `Each radio field must have at least one option available for selection; field of name "${name}" without radioOptions has been ignored.`
       );
       return false;
     }