chore: address feedback

aws-amplify · Feb 26, 2025 · c91adb0 · c91adb0
1 parent 0b19daf
commit c91adb0
Show file tree

Hide file tree

Showing 4 changed files with 24 additions and 17 deletions.
diff --git a/...react-native/src/ui/components/authenticator/sign-in-with-email-mfa-selection/Example.tsx b/...react-native/src/ui/components/authenticator/sign-in-with-email-mfa-selection/Example.tsx
@@ -1,16 +1,18 @@
 import React from 'react';
-import { StyleSheet, View } from 'react-native';
 
-import { Authenticator } from '@aws-amplify/ui-react-native';
+import { StyleSheet, View } from 'react-native';
+import {
+  Authenticator,
+  AuthenticatorProps,
+} from '@aws-amplify/ui-react-native';
 import { Amplify } from 'aws-amplify';
 
 import { SignOutButton } from '../SignOutButton';
 import awsConfig from './aws-exports';
-import { AuthContext } from '@aws-amplify/ui';
 
 Amplify.configure(awsConfig);
 
-const customServices: AuthContext['services'] = {
+const customServices: AuthenticatorProps['services'] = {
   handleSignIn: async () => {
     return {
       isSignedIn: false,
@@ -35,7 +37,7 @@ const customServices: AuthContext['services'] = {
       };
     }
 
-    if (/^\d{6}$/.test(challengeResponse)) {
+    if (challengeResponse === '123456') {
       return {
         isSignedIn: true,
         nextStep: {

diff --git a/...native/src/ui/components/authenticator/sign-in-with-email-mfa-setup-selection/Example.tsx b/...native/src/ui/components/authenticator/sign-in-with-email-mfa-setup-selection/Example.tsx
@@ -1,16 +1,18 @@
 import React from 'react';
-import { StyleSheet, View } from 'react-native';
 
-import { Authenticator } from '@aws-amplify/ui-react-native';
+import { StyleSheet, View } from 'react-native';
+import {
+  Authenticator,
+  AuthenticatorProps,
+} from '@aws-amplify/ui-react-native';
 import { Amplify } from 'aws-amplify';
 
 import { SignOutButton } from '../SignOutButton';
-import { AuthContext, emailRegex } from '@aws-amplify/ui';
 import awsConfig from './aws-exports';
 
 Amplify.configure(awsConfig);
 
-const customServices: AuthContext['services'] = {
+const customServices: AuthenticatorProps['services'] = {
   handleSignIn: async () => {
     return {
       isSignedIn: false,
@@ -29,7 +31,7 @@ const customServices: AuthContext['services'] = {
         },
       };
     }
-    if (emailRegex.test(challengeResponse)) {
+    if (challengeResponse.includes('@example.com')) {
       return {
         isSignedIn: false,
         nextStep: {
@@ -42,7 +44,7 @@ const customServices: AuthContext['services'] = {
         },
       };
     }
-    if (/^\d{6}$/.test(challengeResponse)) {
+    if (challengeResponse === '123456') {
       return {
         isSignedIn: true,
         nextStep: {

diff --git a/examples/react-native/src/ui/components/authenticator/sign-in-with-email-mfa/Example.tsx b/examples/react-native/src/ui/components/authenticator/sign-in-with-email-mfa/Example.tsx
@@ -1,16 +1,18 @@
 import React from 'react';
-import { StyleSheet, View } from 'react-native';
 
-import { Authenticator } from '@aws-amplify/ui-react-native';
+import { StyleSheet, View } from 'react-native';
+import {
+  Authenticator,
+  AuthenticatorProps,
+} from '@aws-amplify/ui-react-native';
 import { Amplify } from 'aws-amplify';
 
 import { SignOutButton } from '../SignOutButton';
 import awsConfig from './aws-exports';
-import { AuthContext } from '@aws-amplify/ui';
 
 Amplify.configure(awsConfig);
 
-const customServices: AuthContext['services'] = {
+const customServices: AuthenticatorProps['services'] = {
   handleSignIn: async () => {
     return {
       isSignedIn: false,
@@ -25,7 +27,7 @@ const customServices: AuthContext['services'] = {
     };
   },
   handleConfirmSignIn: async ({ challengeResponse }) => {
-    if (/^\d{6}$/.test(challengeResponse)) {
+    if (challengeResponse.includes('@example.com')) {
       return {
         isSignedIn: true,
         nextStep: {

diff --git a/...eact-native/src/Authenticator/common/DefaultFormFields/DefaultSelectMfaTypeFormFields.tsx b/...eact-native/src/Authenticator/common/DefaultFormFields/DefaultSelectMfaTypeFormFields.tsx
@@ -2,7 +2,8 @@ import React from 'react';
 
 import { DefaultRadioFormFieldsProps } from './types';
 
-import { Radio, RadioGroup } from '../../../primitives';
+import { RadioGroup } from '../../../primitives/RadioGroup';
+import { Radio } from '../../../primitives/Radio';
 
 const DefaultSelectMfaTypeFormFields = ({
   fields = [],