-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POC(liveness): allow back camera selection #5370
base: liveness/alpha
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
isStartView && | ||
selectableDevices && | ||
selectableDevices.length > 1 && | ||
(!isMobileScreen || (allowBackCamera && isFaceMovementChallenge)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me, only allow camera selection on mobile if allowBackCamera
and is face movement challenge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, this is a very readable conditional, nice work!
@@ -40,6 +40,7 @@ export interface FaceLivenessDetectorCoreProps { | |||
* Optional parameter for advanced options for the component | |||
*/ | |||
config?: FaceLivenessDetectorCoreConfig; | |||
allowBackCamera?: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we will want to have a conversion about whether this should be in the config or a top level prop.
Description of changes
Issue #, if available
Description of how you validated changes
Checklist
yarn test
passes and tests are updated/addeddocs
,e2e
,examples
, or other private packages.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.