-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(authenticator): state machine updates for email mfa #6317
feat(authenticator): state machine updates for email mfa #6317
Conversation
|
cda33cd
to
6497bd2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work overall @jjarvisp. Left some feedback around state duplication that should be pretty straightforward to address, and some nits/questions
packages/ui/src/i18n/dictionaries/authenticator/defaultTexts.ts
Outdated
Show resolved
Hide resolved
packages/ui/src/i18n/dictionaries/authenticator/defaultTexts.ts
Outdated
Show resolved
Hide resolved
9f70329
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
Description of changes
The purpose of this pull request is to add state machine updates required to support Email MFA.
Two new states are added:
CONTINUE_SIGN_IN_WITH_EMAIL_SETUP
CONTINUE_SIGN_IN_WITH_MFA_SETUP_SELECTION
andCONTINUE_SIGN_IN_WITH_MFA_SELECTION
Issue #, if available
Description of how you validated changes
Checklist
yarn test
passes and tests are updated/addeddocs
,e2e
,examples
, or other private packages.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.