Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(authenticator): state machine updates for email mfa #6317

Merged

Conversation

jjarvisp
Copy link
Member

Description of changes

The purpose of this pull request is to add state machine updates required to support Email MFA.

Two new states are added:

  1. Setup Email - CONTINUE_SIGN_IN_WITH_EMAIL_SETUP
  2. Select MFA Type - CONTINUE_SIGN_IN_WITH_MFA_SETUP_SELECTION and CONTINUE_SIGN_IN_WITH_MFA_SELECTION

Issue #, if available

Description of how you validated changes

  • manual testing

Checklist

  • Have read the Pull Request Guidelines
  • PR description included
  • yarn test passes and tests are updated/added
  • PR title and commit messages follow conventional commit syntax
  • If this change should result in a version bump, changeset added (This can be done after creating the PR.) This does not apply to changes made to docs, e2e, examples, or other private packages.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

changeset-bot bot commented Jan 27, 2025

⚠️ No Changeset found

Latest commit: d9ea3a6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

jordanvn
jordanvn previously approved these changes Feb 18, 2025
tiffanynwyeung
tiffanynwyeung previously approved these changes Feb 19, 2025
Copy link
Member

@calebpollman calebpollman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work overall @jjarvisp. Left some feedback around state duplication that should be pretty straightforward to address, and some nits/questions

Copy link
Member

@calebpollman calebpollman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@jjarvisp jjarvisp merged commit 6b9d0f3 into feat-email-mfa/main Feb 28, 2025
36 checks passed
@jjarvisp jjarvisp deleted the james/feat-email-mfa/update-state-machine branch February 28, 2025 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants