Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(authenticator): add react support for email mfa #6319

Merged
merged 45 commits into from
Feb 28, 2025

Conversation

jjarvisp
Copy link
Member

@jjarvisp jjarvisp commented Jan 28, 2025

Description of changes

The purpose of this pull request is to expand authenticator support for email mfa.

The react authenticator now renders two new screens in response to the two new states added to the state machine in #6317. This update allows completion of email MFA based sign ins, email MFA setup, and the selection challenges that allow users to choose which MFA method to setup or sign in with.

  1. selectMfaType -> SelectMfaType : CONTINUE_SIGN_IN_WITH_MFA_SETUP and CONTINUE_SIGN_IN_WITH_MFA_SELECTION
  2. setupEmail -> SetupEmail : CONTINUE_SIGN_IN_WITH_EMAIL_SETUP

Issue #, if available

Description of how you validated changes

  • manual testing
  • e2e testing

Checklist

  • Have read the Pull Request Guidelines
  • PR description included
  • yarn test passes and tests are updated/added
  • PR title and commit messages follow conventional commit syntax
  • If this change should result in a version bump, changeset added (This can be done after creating the PR.) This does not apply to changes made to docs, e2e, examples, or other private packages.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

changeset-bot bot commented Jan 28, 2025

⚠️ No Changeset found

Latest commit: 37a7470

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jjarvisp jjarvisp force-pushed the james/feat-email-mfa/react-updates branch from 2037f6a to 39ba82c Compare January 28, 2025 01:55
@jjarvisp jjarvisp force-pushed the james/feat-email-mfa/update-state-machine branch from cda33cd to 6497bd2 Compare January 28, 2025 02:00
@jjarvisp jjarvisp force-pushed the james/feat-email-mfa/react-updates branch from d25636a to 2d4f5c4 Compare January 29, 2025 23:35
@jjarvisp jjarvisp marked this pull request as ready for review January 31, 2025 00:39
@jjarvisp jjarvisp requested a review from a team as a code owner January 31, 2025 00:39
@jjarvisp jjarvisp force-pushed the james/feat-email-mfa/react-updates branch from a535215 to 432a65b Compare January 31, 2025 01:27
@jjarvisp jjarvisp force-pushed the james/feat-email-mfa/react-updates branch from 432a65b to bf8e959 Compare January 31, 2025 03:01
@jjarvisp jjarvisp force-pushed the james/feat-email-mfa/react-updates branch from bf8e959 to f61ee0b Compare January 31, 2025 03:52
@jjarvisp jjarvisp force-pushed the james/feat-email-mfa/react-updates branch from f61ee0b to 8f49e80 Compare January 31, 2025 17:53
@jjarvisp jjarvisp force-pushed the james/feat-email-mfa/react-updates branch 4 times, most recently from 394dadd to b3ca471 Compare February 11, 2025 22:33
@jjarvisp jjarvisp force-pushed the james/feat-email-mfa/react-updates branch 2 times, most recently from 7f27d61 to c46c2ec Compare February 22, 2025 20:42
@jjarvisp jjarvisp force-pushed the james/feat-email-mfa/react-updates branch from c46c2ec to f69c422 Compare February 22, 2025 20:52
Copy link
Member

@calebpollman calebpollman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to pull down and verify some things but lgtm for the most part, left minor feedback mostly unrelated to implementation

calebpollman
calebpollman previously approved these changes Feb 26, 2025
Base automatically changed from james/feat-email-mfa/update-state-machine to feat-email-mfa/main February 28, 2025 22:07
@jjarvisp jjarvisp dismissed calebpollman’s stale review February 28, 2025 22:07

The base branch was changed.

@jjarvisp jjarvisp merged commit 2da6abf into feat-email-mfa/main Feb 28, 2025
32 checks passed
@jjarvisp jjarvisp deleted the james/feat-email-mfa/react-updates branch February 28, 2025 22:42
@jjarvisp jjarvisp restored the james/feat-email-mfa/react-updates branch February 28, 2025 22:47
@jjarvisp jjarvisp deleted the james/feat-email-mfa/react-updates branch February 28, 2025 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants