-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(authenticator): add react support for email mfa #6319
feat(authenticator): add react support for email mfa #6319
Conversation
|
2037f6a
to
39ba82c
Compare
cda33cd
to
6497bd2
Compare
d25636a
to
2d4f5c4
Compare
examples/next/pages/ui/components/authenticator/email-mfa/index.page.tsx
Outdated
Show resolved
Hide resolved
a535215
to
432a65b
Compare
432a65b
to
bf8e959
Compare
bf8e959
to
f61ee0b
Compare
f61ee0b
to
8f49e80
Compare
394dadd
to
b3ca471
Compare
7f27d61
to
c46c2ec
Compare
c46c2ec
to
f69c422
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to pull down and verify some things but lgtm for the most part, left minor feedback mostly unrelated to implementation
Description of changes
The purpose of this pull request is to expand authenticator support for email mfa.
The react authenticator now renders two new screens in response to the two new states added to the state machine in #6317. This update allows completion of email MFA based sign ins, email MFA setup, and the selection challenges that allow users to choose which MFA method to setup or sign in with.
CONTINUE_SIGN_IN_WITH_MFA_SETUP
andCONTINUE_SIGN_IN_WITH_MFA_SELECTION
CONTINUE_SIGN_IN_WITH_EMAIL_SETUP
Issue #, if available
Description of how you validated changes
Checklist
yarn test
passes and tests are updated/addeddocs
,e2e
,examples
, or other private packages.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.