Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python 3.12 support #1044

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add python 3.12 support #1044

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2981e80
Add python 3.12 support
kddejong Nov 15, 2023
6e3a459
Lifecycle python plugin versions
kddejong Dec 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ def find_version(*file_paths):
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
],
keywords="Amazon Web Services AWS CloudFormation",
)
2 changes: 1 addition & 1 deletion src/rpdk/core/hook/init_hook.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

LOG = logging.getLogger(__name__)
HOOK_TYPE_NAME_REGEX = r"^[a-zA-Z0-9]{2,64}::[a-zA-Z0-9]{2,64}::[a-zA-Z0-9]{2,64}$"
HOOK_PLUGINS = ("java", "python37", "python38", "python39")
HOOK_PLUGINS = ("java", "python38", "python39", "python310", "python311", "python312")


def init_hook(args, project):
Expand Down
2 changes: 2 additions & 0 deletions tests/test_project.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,8 @@
"go1.x",
"python3.8",
"python3.9",
"python3.10",
"python3.11",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about 12?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird dependency issue. It requires a released version of the python plugin that has support for python 3.12 which isn't released yet.

"dotnetcore2.1",
"nodejs10.x",
"nodejs12.x",
Expand Down