Add guard rule to enforce tag property is not create only #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenyez
reviewed
Dec 13, 2024
src/rpdk/guard_rail/rule_library/tags/schema-linter-core-tagging-rules.guard
Outdated
Show resolved
Hide resolved
ammokhov
reviewed
Dec 16, 2024
pultormi
force-pushed
the
tagging-create-only
branch
from
497bf0e to
29fb01d
Compare
pultormi
force-pushed
the
tagging-create-only
branch
from
9170675 to
42a6dd7
Compare
wenyez
approved these changes
Dec 17, 2024
ammokhov
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Tags must be updatable. Therefore, they must not be a create only property of a resource schema. If they are allowed to be create only for a given resource. Tag updatable must be false.
Description of changes:
Added two guard rules to assert that tagProperty cannot be within the create only property list. If it is a create only property, then tagging updatable must be false.
Rules set as warning initially.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.