Add CA immutable fields test #59
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ndbhat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
|
||
| acmpca_validator = ACMPCAValidator(acmpca_client) | ||
| ca = acmpca_validator.assert_certificate_authority(ca_resource_arn, "PENDING_CERTIFICATE") |
There was a problem hiding this comment.
Can you also assert that the resource is in terminal state?
test/e2e/tests/test_ca_activation.py
Outdated
| # assert 'status' in ca_cr['status'] | ||
| # assert ca_cr['status']['status'] == "ACTIVE" |
There was a problem hiding this comment.
why did these get commented out?
There was a problem hiding this comment.
these lines started failing when I removed reconcile: requeue_on_success_seconds: 30 from generator.yaml, getting a fix out in another PR
| // Required to avoid the "declared but not used" error in the default case | ||
| _ = syncCondition |
There was a problem hiding this comment.
won't this just get overwritten the next time someone run generate?
There was a problem hiding this comment.
this code was auto removed when I removed reconcile: requeue_on_success_seconds: 30 from generator.yaml
apis/v1alpha1/generator.yaml
Outdated
| reconcile: | ||
| requeue_on_success_seconds: 30 |
There was a problem hiding this comment.
why did this get removed?
My concern is that you create a CA and the state in ACK shows PENDING_CERTIFICATE for a veryyyy long time now despite the activation resource working successfully.
|
@ndbhat: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Description of changes: Release artifacts for release v0.0.19 Merge after #59 is merged By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description of changes: 1. Adding test case to check that the CA resource recovers after immutable fields are updated By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.