fix: ignore create and update outputs for Rule #63
Conversation
Currently, when AWS returns the output of CreateRule or UpdateRule, it returns a list of Actions, which hold TargetGroupArns. TargetGroups can also be referenced from a k8s TargetGroup object. When AWS returns the list of Actions, the generated code creates a new Action struct and populates it with the values from the sdk output (which do not include the references). If the user sets a targetGroupRef, we do not have a way to figure out the correct Action to assign the returned targetGroupRef. This proposed change ignores setting Actions returned by AWS. This should be safe to do so, since the Action AWS returns is expected to be the same one the user defined in their custom resource, ensuring any references in the field are not lost.
|
@michaelhtm: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/hold |
ack-prow
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, michaelhtm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2 participants
Issue #2652
Description of changes:
Currently, when AWS returns the output of CreateRule or UpdateRule,
it returns a list of Actions, which hold TargetGroupArns.
TargetGroups can also be referenced from a k8s TargetGroup object.
When AWS returns the list of Actions, the generated code creates a new
Action struct and populates it with the values from the sdk output
(which do not include the references).
If the user sets a targetGroupRef, we do not have a way to figure out
the correct Action to assign the returned targetGroupRef.
This proposed change ignores setting Actions returned by AWS. This
should be safe to do so, since the Action AWS returns is expected to be
the same as the one the user defined in their custom resource, ensuring any
references in the field are not lost.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.