Skip to content

Conversation

a-hilaly
Copy link
Member

@a-hilaly a-hilaly commented Sep 24, 2025

Add informational logging when a read-only resource's desired state
differs from its current state. This helps operators understand what
changes would have been applied if the resource wasn't in read-only mode.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from jlbutler and knottnt September 24, 2025 15:39
@ack-prow ack-prow bot added the approved label Sep 24, 2025
@a-hilaly a-hilaly changed the title Log delta differences in read-only mode feat: log delta differences for read-only resources when spec changes Sep 24, 2025
@a-hilaly
Copy link
Member Author

/retest

2 similar comments
@knottnt
Copy link

knottnt commented Sep 30, 2025

/retest

@a-hilaly
Copy link
Member Author

/retest

Copy link

ack-prow bot commented Sep 30, 2025

@a-hilaly: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
verify-attribution eeffc02 link false /test verify-attribution
unit-test eeffc02 link true /test unit-test
sagemaker-controller-test eeffc02 link true /test sagemaker-controller-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link

@knottnt knottnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

ack-prow bot commented Oct 1, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, knottnt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants