fix: expand ~ to user home dir

Signed-off-by: Jericho Tolentino <[email protected]>

src/deadline/job_attachments/download.py

@@ -1117,10 +1117,13 @@ def set_root_path(self, original_root: str, new_root: str) -> None:
         """
         Changes the root path for downloading output files, (which is the root path
         saved in the S3 metadata for the output manifest by default,) with a custom path.
-        (It will store the new root path as an absolute path.)
+        The `new_root` path will have the following transformations applied:
+        - Normalizes the path with `os.path.normpath` (e.g. removes unnecessary relative paths `..`)
+        - Expands leading tilde (~) character to corresponding user home directory with pathlib.Path.expanduser
+        - Makes the path absolute if a relative path is given (prepends current working directory) with pathlib.Path.absolute
         """
         # Need to use absolute to not resolve symlinks, but need normpath to get rid of relative paths, i.e. '..'
-        new_root = str(os.path.normpath(Path(new_root).absolute()))
+        new_root = str(os.path.normpath(Path(new_root).expanduser().absolute()))
 
         if original_root not in self.outputs_by_root:
             raise ValueError(

test/unit/deadline_job_attachments/test_download.py

@@ -1304,6 +1304,27 @@ def test_OutputDownloader_set_root_path_wrong_root_throws_exception(
         with pytest.raises(ValueError):
             output_downloader.set_root_path(original_root="/wrong_root", new_root="/new_root_path")
 
+    @mock_aws
+    def test_OutputDownloader_set_root_path_expanduser(self) -> None:
+        # GIVEN
+        mock_outputdownloader = MagicMock()
+        original_root = os.path.join("/tmp", "original_root")
+        new_root = os.path.join("~", "asset_root")
+        mock_outputdownloader.outputs_by_root = {
+            original_root: "groot",
+        }
+
+        # WHEN
+        OutputDownloader.set_root_path(
+            self=mock_outputdownloader,
+            original_root=original_root,
+            new_root=new_root,
+        )
+
+        # THEN
+        assert len(mock_outputdownloader.outputs_by_root) == 1
+        assert os.path.expanduser(new_root) in mock_outputdownloader.outputs_by_root
+
     @mock_aws
     def test_OutputDownloader_download_job_output_when_skip(
         self, farm_id, queue_id, tmp_path: Path