Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: state upperbound (3.12) for python version support #501

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

amarsjac
Copy link
Contributor

@amarsjac amarsjac commented Nov 15, 2024

Fixes: #493

What was the problem/requirement? (What/Why)

Dependencies required for the library do not exist for python 3.13

What was the solution? (How)

put in version cap into pyproject.toml file to prevent pip installing on python 3.13

What is the impact of this change?

Users will no longer be able to pip install the library if python version is >=3.13

How was this change tested?

hatch build

Was this change documented?

  • Are relevant docstrings in the code base updated?
  • Has the README.md been updated? If you modified CLI arguments, for instance.

Does this PR introduce new dependencies?

This library is designed to be integrated into third-party applications that have bespoke and customized deployment environments. Adding dependencies will increase the chance of library version conflicts and incompatabilities. Please evaluate the addition of new dependencies. See the Dependencies section of DEVELOPMENT.md for more details.

  • This PR adds one or more new dependency Python packages. I acknowledge I have reviewed the considerations for adding dependencies in DEVELOPMENT.md.
  • This PR does not add any new dependencies.

Is this a breaking change?

yes this removes pip support for python 3.13

Does this change impact security?

no

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@amarsjac amarsjac requested a review from a team as a code owner November 15, 2024 21:49
@amarsjac amarsjac marked this pull request as draft November 15, 2024 22:24
@amarsjac amarsjac closed this Nov 15, 2024
@amarsjac amarsjac reopened this Nov 15, 2024
@amarsjac amarsjac marked this pull request as ready for review November 15, 2024 22:31
@epmog epmog changed the title chore!: Remove offical support for python 3.13 fix: state upperbound (3.12) for python version support Nov 15, 2024
@epmog epmog merged commit f35765f into aws-deadline:mainline Nov 15, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: pip install fails on Windows with Python 3.13
3 participants