Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update submit job to deadline dialog height #582

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

shaurysh
Copy link
Contributor

@shaurysh shaurysh commented Jan 30, 2025

What was the problem/requirement? (What/Why)

  • The addition of maxWorkerCount added a scrollbar by default.
  • Fixing the default height of the submit to AWS Deadline Cloud Job Dialog box to avoid having to see the scroll bar

What was the solution? (How)

  • Updated the height of the Submit to AWS Deadline Cloud Dialog box.

What is the impact of this change?

  • Customers dont see a vertical scroll bar when they open the GUI for the first time!

How was this change tested?

  • Ran hatch build
  • Ran deadline bundle gui-submit --browse command, selected a job bundle and verified that the scroll bar was gone!

See DEVELOPMENT.md for information on running tests.

  • Have you run the unit tests? - YES
  • Have you run the integration tests? - NO (only a UI side fix)
  • Have you made changes to the download or asset_sync modules? If so, then it is highly recommended
    that you ensure that the docker-based unit tests pass. - NO

Was this change documented?

  • Are relevant docstrings in the code base updated? - N/A
  • Has the README.md been updated? If you modified CLI arguments, for instance. - N/A

Does this PR introduce new dependencies?

This library is designed to be integrated into third-party applications that have bespoke and customized deployment environments. Adding dependencies will increase the chance of library version conflicts and incompatabilities. Please evaluate the addition of new dependencies. See the Dependencies section of DEVELOPMENT.md for more details.

  • [ ❌ ] This PR adds one or more new dependency Python packages. I acknowledge I have reviewed the considerations for adding dependencies in DEVELOPMENT.md.
  • [ ✅ ] This PR does not add any new dependencies.

Is this a breaking change?

A breaking change is one that modifies a public contract in a way that is not backwards compatible. See the
Public Contracts section
of the DEVELOPMENT.md for more information on the public contracts.

If so, then please describe the changes that users of this package must make to update their scripts, or Python applications.

  • NO

Does this change impact security?

  • Does the change need to be threat modeled? For example, does it create or modify files/directories that must only be readable by the process owner?
    • If so, then please label this pull request with the "security" label. We'll work with you to analyze the threats.
  • NO

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@shaurysh shaurysh requested a review from a team as a code owner January 30, 2025 00:13
@epmog epmog enabled auto-merge (squash) January 30, 2025 20:08
@epmog epmog merged commit a99033a into aws-deadline:mainline Jan 30, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants