fix: Priority box now has correct range. #589
Open
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric Osiowy <[email protected]>
|
ttblanchard
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #575
What was the problem/requirement? (What/Why)
The Priority spinbox was capped at 99, but the documentation for Deadline says that it should be 100.
What was the solution? (How)
I updated the range for the spinbox to match what's in the Deadline documentation. https://docs.aws.amazon.com/deadline-cloud/latest/userguide/deadline-cloud-jobs.html
It's set to 1-100 now.
What is the impact of this change?
Priority is now correctly limited.
How was this change tested?
Updated unit test and ran deadline bundle gui-submit to check that the spinbox limits was updated correctly.
Was this change documented?
No.
Does this PR introduce new dependencies?
Is this a breaking change?
No.
Does this change impact security?
No.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.