Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrum 150 frontend create template #44

Merged
merged 9 commits into from
Dec 4, 2024

Conversation

chungchihhan
Copy link
Collaborator

@chungchihhan chungchihhan commented Dec 1, 2024

Description

  1. 使用者原先無法自定檔案名稱,增加檔案名稱輸入欄位,讓使用者可以自訂檔名
  2. 檔名如果空白無法按save template button
  3. save template成功會跳出toast通知在右上角
  4. 更新部分component file names以符合程式碼規範

Type of Change

  • 🐛 Bug Fix(修復 bug)
  • ✨ New Feature(新功能)
  • 💄 UI/UX(介面或使用者體驗優化)
  • 🔨 Refactor(程式碼重構)
  • 📝 Documentation(文件更新)
  • 🔧 Configuration(配置變更)
  • 🚀 Performance(效能優化)
  • ✅ Test(測試相關)
  • 🔒 Security(安全性相關)

Related Issues

SCRUM-150

Testing

  • 完成code format以及lint check:已經執行 npm run fix

Screenshots/Videos

Screen Recording 2024-12-01 at 3.55.53 PM_2.mov.zip

Checklist

  • 我已經測試過這些變更
  • 我已經更新相關文件
  • 我的程式碼遵循專案的程式碼規範
  • 我已經處理所有的 console warnings/errors
  • 我已經移除所有的 console.log
  • 我已經新增必要的測試案例
  • 所有現有的測試都能通過

Additional Notes

Copy link

vercel bot commented Dec 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
email-sender ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2024 2:20am

@poyang1024
Copy link
Collaborator

@chungchihhan
一個小問題

  1. PO 在票上 Attachments 中的圖片中有放期待看到的樣子,現在看起來少了一個叫做 file name 的 label ,補上再排個版應該就可以了

其他讚讚!!

@chungchihhan
Copy link
Collaborator Author

chungchihhan commented Dec 4, 2024

Hi @poyang1024 ,
I have added the text you mentioned !

image

@poyang1024
Copy link
Collaborator

LGTM!! nice

@chungchihhan chungchihhan merged commit 3df1e1a into dev-new Dec 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants