Scrum 189 fix error of not showing trigger webhook api #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
也是小好奇 failed to create webhook url 的情境有什麼 |
poyang1024
reviewed
Dec 16, 2024
src/app/ui/create-webhook-form.tsx
Outdated
Comment on lines
96
to
100
| if ( | ||
| response.status === "error" && | ||
| response.errors && | ||
| response.message === "Validation failed" | ||
| ) { |
There was a problem hiding this comment.
Hi @poyang1024 ,這邊的話是為了確保情況是我們要的，但確實有可改進之處, 明天會再修正感謝
There was a problem hiding this comment.
Hi @chungchihhan ,
其實如果合理且是為了完全吻合使用者情境的話是可以這樣寫拉，不過可能就要讓開發者都 sync 一下後端會有多少的 status,errors,message
src/app/ui/create-webhook-form.tsx
Outdated
Comment on lines
110
to
114
| // for api error checked | ||
| if ( | ||
| response.status === "error" && | ||
| response.message === "Failed to create webhook. Please try again." | ||
| ) { |
|
Hi @poyang1024 , 上述判斷式已經優化修正，感謝 |
poyang1024
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
因為POST /webhook 這隻 API Request Body有所變更，多了必填的
webhook_type，因此導致前端無法正常使用，另外加上error的toast來告知 api 出現問題Type of Change
Related Issues
SCRUM-189
Testing
Screenshots/Videos
創建成功：
成功複製url :
api回傳error或者有必填沒有填寫
(e.g. 如果前端發送的request body缺乏
webhook_type,webhook_type是必填，因此api response的status會是error. )Checklist
Additional Notes