Update Geofence Lambda to incorporate CF update condition for geofenc… #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbalfour-amzn
approved these changes
Jun 20, 2024
Comment on lines
929
to
931
| elif event['RequestType'] == "Delete": | ||
| for route in routes: | ||
| id = route['id'] | ||
| collectionName = ('location.aws.com.demo.geofences.' + route['geofenceCollection']) | ||
| try: | ||
| geofence_collection = client.delete_geofence_collection( | ||
| CollectionName=collectionName | ||
| ) | ||
| except client.exceptions.ResourceNotFoundException: | ||
| pass # If the collection does not exist, continue | ||
| responseValue = 120 | ||
| responseData = {'Data': responseValue} | ||
| cfnresponse.send(event, context, cfnresponse.SUCCESS, responseData, 'AmazonLocationDemoGeofenceCreator') |
There was a problem hiding this comment.
Suggested on other CR as well, but this could be moved above the Create/Update if as if event['RequestType'] in ["Delete", "Update"]: to avoid duplicating the delete logic. The cfnresponse.send() would need to be pulled out of the if blocks though to prevent the Update case from reporting success too early.
wadhawh
force-pushed
the
fix/geofence_lambda
branch
from
8ac1913 to
84aa79f
Compare
mbalfour-amzn
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…es update
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.