Feature als 1591 web responsive #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix for ALS-1457 debounced search
- fixed border bottom rounded issue while searching and when not found card appears - fixed search shaking and height when search has no result or loading
* added check to reconnect websocket when disconnects * fixed tooltip position * changed UI for web socket connection * improved web socket connection logic for tracker box * replaced colors & UI according to design
fixed clear filters button styling
…date default CF template
* fix pageViewDuration * add pageViewIdentifier to track actions per page view
…nsive_main [Makeen] [Feature ALS-1591] mobile and tablet responsiveness
…nsive_main [Makeen] [Feature ALS-1591] web responsiveness
…nsive_main [Makeen] [Feature ALS-1591] resolved unauth simulation issue
…nsive_main [Makeen] [Feature ALS-1591] web responsive
…nsive_main [Makeen] [Feature ALS-1591] web responsiveness
…nsive_main [Makeen] [Feature ALS-1591] updated simulation speed
vinguthh
reviewed
Oct 13, 2023
| @@ -31,6 +31,7 @@ Resources: | |||
| - Action: | |||
| - "mobiletargeting:PutEvents" | |||
| - "mobiletargeting:UpdateEndpoint" | |||
| - "mobiletargeting:GetEndpoint" | |||
There was a problem hiding this comment.
Can you create a task as a follow up to limit growers access to the unauth acess?
I'm thinking we should use aws:referer as policy condition to our website to only requests from our webs to use unauth cognito.
There was a problem hiding this comment.
There was a problem hiding this comment.
Yes @vinguthh we can definitely do that via aws:referer, below are the links we can whitelist for web
- http://localhost:3000
- https://dev.amazonlocation.services
- https://qa.amazonlocation.services
- https://webapp.beta.geo.waypoint.aws.dev
- https://webapp.gamma.geo.waypoint.aws.dev
- https://location.aws.com
@wadhawh can you kindly update the template accordingly? And if we can also whitelist for iOS and Android.
There was a problem hiding this comment.
Thanks, can you help create a ticket to track this.
vinguthh
pushed a commit
that referenced
this pull request
Oct 18, 2023
* fixed the banner issue when user connected back once it is closed (#21) * fixed dynamic text issue on auto when toggling units * unauth simulation, analytics, localization, translation script and update default CF template * add footer in TriggeredByEnum and fix tests (#39) * localization fixes for terms page, auth geofence box * add pageViewDuration in LEAVE_PAGE event (#40) * Improve leave page event attr (#44) * fix pageViewDuration * add pageViewIdentifier to track actions per page view * placeholder for the loading state during the search operation. (#45) * merged lib approach * translated chinese in language dropdown * improve pageViewIdentifier storage (#46) * fixed text responsive issues with button (#42) * updated README * Dynamically Localize Number Formats for International User Support (#47) * fixed text & added new script to update translation (#48) * updated regex to support geofence name in multiple languages * Updated CF templates (#49) * Remove useRecordViewPage from DemoPlaceholderPage and amend page identifier key (#50) * Update main-cf-template.yaml * Update main-cf-template.yaml * fixes callback to show auth tracker box * removed log * Improve analytics (#51) * log session_end event and improve page identifiers storage * remove pageViewDuration * amend pageViewIdentifier * Add Open Data Maps to demo app (#52) * Addeede open data provider * completed adding open data provider * fixed attribute color issue with visualization dark mode * fixed build issues and updated name for translation script * Feat/change country approach (#53) * change the country fetching approach, also remove initiateAnalytics * add COUNTRY_EVALUATION_URL env variable * fix env variables * return undefined if the country code is Unknown getCountryCode * revert stopsession debouce time and remove logs * set default COUNTRY_EVALUATION_URL * unauth simulation fixes - removed geofence border, fixed animation, updated icons * Add the ability to dynamic evaluate and assign fastest region (#54) * change env variable for multiple identity pool ids (#56) * change env variable for multiple identity pool ids * fix useEffect error in useRecordViewPage * Fixed unauth simulation ui issues (#55) * fixed unauth simulation ui issues * removed unused import * fixed unauth tracking history left icon alignment * fixed notification icon size * Allowed duplicates geeofence notifications for unauth * fixed button hover for primary button * updated env and websocket urls approach * removed log * updated env * library format changed from es to cjs (#57) * Revert "library format changed from es to cjs (#57)" (#58) This reverts commit c4f2fa2. * updated language icon ins settings modal * added option in settings modal to select region * updated translations * add geofence notification case in cypress tests (#60) * fixed dot issue in arabic and hebrew, fixed the RTL issue with short distance unit (#61) * fixed dot issue in arabic and hebrew, fixed the rtl issue with short unit * fixed short units translation * fixed paused simulation issue when active the other routes & fixed spelling for trackers * improved the short distance unit ui * region and opendata ui fix * fixes for unauth simulation * Added kinesis resources & updated pinpoint event stream (#62) Co-authored-by: Harshit Wadhawan <[email protected]> * updated readme * updated readme * fixed translation issues (#63) * introduced react-spring-bottom-sheet * add unit test for Pinpoint Analytics (#64) * add security.txt (#65) * switched to npm and locked dep versions * added CSP to meta tag * implemented the Explore UI for mobile and tablet * added manifest-src to CSP meta tag * added manifest-src data to CSP meta tag * Update default-unauth-resources-template.yaml * updated readme * added fix for unauth creds expiry issue * Update default-unauth-resources-template.yaml * updated CSP * Improve enahnce analytics test (#68) * mock countryUtil.getCountryCode * add more failure test cases in PinpointAnalytics test * remove recording of search value in location search * removed CSP meta tag * updated default CF template * potential fix for multi notifications for unauth and auth simulations, reset map to default when region switched * udpated translations * completed map style responsive UI * updated E2E tests * added cory's feedback * updated e2e tests * fixed failing E2E tests * updated CSP * on going search box * fixed POI Card * fixed issues with direction * updated attribution setting logic * added hash to script-src * on going routes ui * [ALS-1636] geofence tooltip position update * search issue, udpated short unit notation * updated websocket URL logic * updated default CF template * [ALS-1643] render geofences on list view * ongoing routes * ongoing responsiveness task for tracker & geofence * tracker & geofence * built UI for tracker & geofence for tablet and mobile * fixed search issue * applied edit icon along with mobile icon for simulation * fixed close icon for geofence * fixed & complete settings & about UI for tablet and mobile * built routes/direction * improved experience * removed extra // onBlur={() => isBothInputFilled && onFocus(InputType.FROM, true)} * removed unsued import * fixed arrow up down issue with routes * Merge branch 'main' into feature_ALS-1591_web-responsive_main * fixed logo position * cleanup * hid the mapbutton, tracker and geofence on the map according to responsiveness need * cleanup * fixed closing of unath simulation * fixed type issues for build * [ALS-1591] updated state issue * fixed few issues with responsiveness * removed console.log * removed extra css * fixed scroll issue with search * map focus on routing fix * blank white space fix * changed mobile breakpoint to 430px * fixed map provider search param issue and current location issue * fixed sticky search bar and blank space issue * fixed poi card styling * fixed welcome modal, about modal * fixed scrolling issue * fixed close button issue with auth tracker * fixes for unauth simulation UI * changed explore min height * fixed ui issues with scrolling and padding * fixed few things * fixed route UI for mobile and tablet * fixed map styles UI issues along with closing issue on ios and updated a text * uncommented connect to aws click handler * fixed button active state on tablet and mobile * fixed button active state on tablet and mobile * fixed pull refresh issue * fixed pull refresh issue * fixed welcome modal UI, dropdown and connect AWS modal * removed extra css * fixed welcome modal UI and About modal UI * fixed auth simulation zoom and focus issues, added links to logo * fixed routes steps * fixed map styles opening * implemented arrow icons on bottom sheet header * fixed routes step * fixed vancouver bounds for tablet and mobile * fixed few issues * implemented scrollbar hidding and fixed attribute button styling * removed body overflow hidden * enabled route history for all devices * fixed logo issue * [ALS-1671] fixed space issue for numbers in french * removed log * updated failing tests * updated github workflow * updated failing tests * mocked reload * refined secrets * refined secrets * updated e2e test * updated workflow files * reverted workflow file changes * updated attributions and data provider search param * loggin env for all workflows * logging env for all workflows * removed log * logging env in workflow * reverted logging env in workflow * updated security-tests .env.example * responsive fixes * fixed few issues * fix height of auth tracker/geofence * cleanup * added close icon in bottom sheet header & fixed ui * fixed build failure * fixed closing issue on routes and poi card * cleanup * fixed minor issues * fixed placeholder glitch for mobile * cleanup * fixed minor issues raised in regression * fixed setting modal initial option issue * fixed replaceAll issue * fixed replaceAll issue * resolved build errors * updated toast implementation to be overlapping * fixed socket banner padding issue * fixed exit simulation modal, bottom sheet expanding issue with search, routes and map styles * removed comment * fixed scroll issue in bottom sheet, glitch issue with bottom sheet * fixes failing tests and updated map styles responsive logic * fixes failing tests and updated map styles responsive logic * unauth simulation exit modal fix * fixed map styles issues on tablet during unauth simulation, added and updated notifications for enter and exit events during unauth simulaiton * removed geofence and tracker shortcuts when unauth simulation enabled * implemented 40 percent height on bottom sheet * fixed search placeholder * fixed geofence and tracker shortcut functionality * fixed opening issue with routes and explore ui * updated fitbounds for route on mobile screen * fixed my location selection issue * minor fix * fixed poi card issue * removed background * resolved unauth simulation issue * fitbounds functionality update, and updated unit tests * removed log * poi card issue * fixed height issue on ipad * mapstyles search fix * fixed routes and search issues with height * fixed routes and search issues with height * unauth exit modal for mobile and tablet fix * updated simulation speed * fixed aws connect modal keyboard closing and routes issue * fixed route not found on poi card * hide GrabMaps when unauth simulation is open * fixed tootip greyed out issue * resolved region issue with connecting AWS account --------- Co-authored-by: Dabeer Raza <[email protected]> Co-authored-by: Ahmad Azizi <[email protected]> Co-authored-by: NihaalAftab-Makeen <[email protected]> Co-authored-by: harshit-makeen <[email protected]> Co-authored-by: Harshit Wadhawan <[email protected]> Co-authored-by: wadhawh <[email protected]>
vinguthh
pushed a commit
that referenced
this pull request
Oct 19, 2023
* localization fixes for terms page, auth geofence box * add pageViewDuration in LEAVE_PAGE event (#40) * Improve leave page event attr (#44) * fix pageViewDuration * add pageViewIdentifier to track actions per page view * placeholder for the loading state during the search operation. (#45) * merged lib approach * translated chinese in language dropdown * improve pageViewIdentifier storage (#46) * fixed text responsive issues with button (#42) * updated README * Dynamically Localize Number Formats for International User Support (#47) * fixed text & added new script to update translation (#48) * updated regex to support geofence name in multiple languages * Updated CF templates (#49) * Remove useRecordViewPage from DemoPlaceholderPage and amend page identifier key (#50) * Update main-cf-template.yaml * Update main-cf-template.yaml * fixes callback to show auth tracker box * removed log * Improve analytics (#51) * log session_end event and improve page identifiers storage * remove pageViewDuration * amend pageViewIdentifier * Add Open Data Maps to demo app (#52) * Addeede open data provider * completed adding open data provider * fixed attribute color issue with visualization dark mode * fixed build issues and updated name for translation script * Feat/change country approach (#53) * change the country fetching approach, also remove initiateAnalytics * add COUNTRY_EVALUATION_URL env variable * fix env variables * return undefined if the country code is Unknown getCountryCode * revert stopsession debouce time and remove logs * set default COUNTRY_EVALUATION_URL * unauth simulation fixes - removed geofence border, fixed animation, updated icons * Add the ability to dynamic evaluate and assign fastest region (#54) * change env variable for multiple identity pool ids (#56) * change env variable for multiple identity pool ids * fix useEffect error in useRecordViewPage * Fixed unauth simulation ui issues (#55) * fixed unauth simulation ui issues * removed unused import * fixed unauth tracking history left icon alignment * fixed notification icon size * Allowed duplicates geeofence notifications for unauth * fixed button hover for primary button * updated env and websocket urls approach * removed log * updated env * library format changed from es to cjs (#57) * Revert "library format changed from es to cjs (#57)" (#58) This reverts commit c4f2fa2. * updated language icon ins settings modal * added option in settings modal to select region * updated translations * add geofence notification case in cypress tests (#60) * fixed dot issue in arabic and hebrew, fixed the RTL issue with short distance unit (#61) * fixed dot issue in arabic and hebrew, fixed the rtl issue with short unit * fixed short units translation * fixed paused simulation issue when active the other routes & fixed spelling for trackers * improved the short distance unit ui * region and opendata ui fix * fixes for unauth simulation * Added kinesis resources & updated pinpoint event stream (#62) Co-authored-by: Harshit Wadhawan <[email protected]> * updated readme * updated readme * fixed translation issues (#63) * introduced react-spring-bottom-sheet * add unit test for Pinpoint Analytics (#64) * add security.txt (#65) * switched to npm and locked dep versions * added CSP to meta tag * implemented the Explore UI for mobile and tablet * added manifest-src to CSP meta tag * added manifest-src data to CSP meta tag * Update default-unauth-resources-template.yaml * updated readme * added fix for unauth creds expiry issue * Update default-unauth-resources-template.yaml * updated CSP * Improve enahnce analytics test (#68) * mock countryUtil.getCountryCode * add more failure test cases in PinpointAnalytics test * remove recording of search value in location search * removed CSP meta tag * updated default CF template * potential fix for multi notifications for unauth and auth simulations, reset map to default when region switched * udpated translations * completed map style responsive UI * updated E2E tests * added cory's feedback * updated e2e tests * fixed failing E2E tests * updated CSP * on going search box * fixed POI Card * fixed issues with direction * updated attribution setting logic * added hash to script-src * on going routes ui * [ALS-1636] geofence tooltip position update * search issue, udpated short unit notation * updated websocket URL logic * updated default CF template * [ALS-1643] render geofences on list view * ongoing routes * ongoing responsiveness task for tracker & geofence * tracker & geofence * built UI for tracker & geofence for tablet and mobile * fixed search issue * applied edit icon along with mobile icon for simulation * fixed close icon for geofence * fixed & complete settings & about UI for tablet and mobile * built routes/direction * improved experience * removed extra // onBlur={() => isBothInputFilled && onFocus(InputType.FROM, true)} * removed unsued import * fixed arrow up down issue with routes * Merge branch 'main' into feature_ALS-1591_web-responsive_main * fixed logo position * cleanup * hid the mapbutton, tracker and geofence on the map according to responsiveness need * cleanup * fixed closing of unath simulation * fixed type issues for build * [ALS-1591] updated state issue * fixed few issues with responsiveness * removed console.log * removed extra css * fixed scroll issue with search * map focus on routing fix * blank white space fix * changed mobile breakpoint to 430px * fixed map provider search param issue and current location issue * fixed sticky search bar and blank space issue * fixed poi card styling * fixed welcome modal, about modal * fixed scrolling issue * fixed close button issue with auth tracker * fixes for unauth simulation UI * changed explore min height * fixed ui issues with scrolling and padding * fixed few things * fixed route UI for mobile and tablet * fixed map styles UI issues along with closing issue on ios and updated a text * uncommented connect to aws click handler * fixed button active state on tablet and mobile * fixed button active state on tablet and mobile * fixed pull refresh issue * fixed pull refresh issue * fixed welcome modal UI, dropdown and connect AWS modal * removed extra css * fixed welcome modal UI and About modal UI * fixed auth simulation zoom and focus issues, added links to logo * fixed routes steps * fixed map styles opening * implemented arrow icons on bottom sheet header * fixed routes step * fixed vancouver bounds for tablet and mobile * fixed few issues * implemented scrollbar hidding and fixed attribute button styling * removed body overflow hidden * enabled route history for all devices * fixed logo issue * [ALS-1671] fixed space issue for numbers in french * removed log * updated failing tests * updated github workflow * updated failing tests * mocked reload * refined secrets * refined secrets * updated e2e test * updated workflow files * reverted workflow file changes * updated attributions and data provider search param * loggin env for all workflows * logging env for all workflows * removed log * logging env in workflow * reverted logging env in workflow * updated security-tests .env.example * responsive fixes * fixed few issues * fix height of auth tracker/geofence * cleanup * added close icon in bottom sheet header & fixed ui * fixed build failure * fixed closing issue on routes and poi card * cleanup * fixed minor issues * fixed placeholder glitch for mobile * cleanup * fixed minor issues raised in regression * fixed setting modal initial option issue * fixed replaceAll issue * fixed replaceAll issue * resolved build errors * updated toast implementation to be overlapping * fixed socket banner padding issue * fixed exit simulation modal, bottom sheet expanding issue with search, routes and map styles * removed comment * fixed scroll issue in bottom sheet, glitch issue with bottom sheet * fixes failing tests and updated map styles responsive logic * fixes failing tests and updated map styles responsive logic * unauth simulation exit modal fix * fixed map styles issues on tablet during unauth simulation, added and updated notifications for enter and exit events during unauth simulaiton * removed geofence and tracker shortcuts when unauth simulation enabled * implemented 40 percent height on bottom sheet * fixed search placeholder * fixed geofence and tracker shortcut functionality * fixed opening issue with routes and explore ui * updated fitbounds for route on mobile screen * fixed my location selection issue * minor fix * fixed poi card issue * removed background * resolved unauth simulation issue * fitbounds functionality update, and updated unit tests * removed log * poi card issue * fixed height issue on ipad * mapstyles search fix * fixed routes and search issues with height * fixed routes and search issues with height * unauth exit modal for mobile and tablet fix * updated simulation speed * fixed aws connect modal keyboard closing and routes issue * fixed route not found on poi card * hide GrabMaps when unauth simulation is open * fixed tootip greyed out issue * resolved region issue with connecting AWS account * reoslved hover issue for connect aws account button * scroll issue for long languages on connect aws modal and kewdale poi issue --------- Co-authored-by: Ahmad Azizi <[email protected]> Co-authored-by: NihaalAftab-Makeen <[email protected]> Co-authored-by: Dabeer Raza <[email protected]> Co-authored-by: harshit-makeen <[email protected]> Co-authored-by: Harshit Wadhawan <[email protected]> Co-authored-by: wadhawh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of the responsive UI on tablets and mobile.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.