Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding NL Places Search UI & Functionality #83

Merged
merged 4 commits into from
Nov 7, 2023

Conversation

TheRBajaj
Copy link
Contributor

@TheRBajaj TheRBajaj commented Nov 2, 2023

  • includes toggle to activate nl places search
  • NL search UI will only be present if correct env variables are set
  • added appropriate cypress and jest tests for all NL Search related components code refactor

Screenshots

image image

Cypress

  • Cypress test for userIsableToSearch is intended to fail as workflow tests cypress with different web domain

working test with local web domain:
image

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@its-aazizi
Copy link
Collaborator

  1. The textual content has only been added to en.json. It needs to be added to update-en.json and then translated using the translation script under /extra folder. The content also needs to be added to marketing repo, because when the build is created the demo lib uses locales from the marketing repo.
  2. I see that 2 new ENV variables have been introduced. Shouldn't the default CF template also be updated to create those resources under /extra/cloudformation/default-unauth-resources-template.yaml?
  3. .env and .env.example also needs to be updated in the marketing repo. Since during build, demo lib will be created using the env from the marketing repo.

Let me know if anything is unclear, and I'll be more than happy to hop on a call and clarify.

CC: @vinguthh @TheRBajaj

@TheRBajaj
Copy link
Contributor Author

TheRBajaj commented Nov 7, 2023

  1. The textual content has only been added to en.json. It needs to be added to update-en.json and then translated using the translation script under /extra folder. The content also needs to be added to marketing repo, because when the build is created the demo lib uses locales from the marketing repo.
  2. I see that 2 new ENV variables have been introduced. Shouldn't the default CF template also be updated to create those resources under /extra/cloudformation/default-unauth-resources-template.yaml?
  3. .env and .env.example also needs to be updated in the marketing repo. Since during build, demo lib will be created using the env from the marketing repo.

Let me know if anything is unclear, and I'll be more than happy to hop on a call and clarify.

CC: @vinguthh @TheRBajaj

  1. Issue has been resolved. added textual data using translation script for demo-web. Also updated it for merketing demo (PR to follow)
  2. these two new env variables are optional for now since this feature will only go to pre-prod for now
  3. updated .env.example to reflect the new optional env variables (PR to follow on marketing repo)

- includes toggle to activate nl places search
- NL search UI will only be present if correct env variables are set
- added appropriate cypress and jest tests for all NL Search related components
code refactor
@TheRBajaj TheRBajaj merged commit b1bba59 into main Nov 7, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants