Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump bouncycastle dependency version #93

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

saranyailla
Copy link
Member

@saranyailla saranyailla commented Nov 21, 2024

Issue #, if available:

Description of changes:
aws-encryption-sdk-java - 2.2.0 relies on bouncy castle bcprov-ext-jdk15on - 1.68. So, we can't just update the bouncy castle version to bcprov-jdk18on - 1.78.1 as those are treated as two separate libraries causing inconsistent results during runtime.

This change updates both aws-encryption-sdk-java - 3.0.1 (major version bump which needs AWS SDK v2) which brings in bcprov-jdk18on - 1.78.1 version of bouncy castle.

Why is this change necessary:

How was this change tested:

Any additional information or context required to review the change:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@saranyailla saranyailla force-pushed the bump-deps branch 2 times, most recently from 3b37009 to fe955a4 Compare November 21, 2024 18:37
Copy link

github-actions bot commented Nov 21, 2024

Unit Tests Coverage Report

File Coverage Lines Branches
All files 91% 92% 90%

Minimum allowed coverage is 65%

Generated by 🐒 cobertura-action against 1bb7a91

@saranyailla saranyailla force-pushed the bump-deps branch 3 times, most recently from 014937d to 1bb7a91 Compare November 21, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant