Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update documentation for installing EFA device plugin to use official EKS chart #850

Merged

Conversation

bryantbiggs
Copy link
Contributor

@bryantbiggs bryantbiggs commented Mar 13, 2024

Description:

  • Update documentation for installing EFA device plugin to use official EKS chart

We would like to remove the sample manifests provided in aws-samples/aws-efa-eks#22 (comment) and instead refer users to the official device plugin Helm chart.

MANDATORY: PR needs test run output

Test Run Output:
Please specify the release version, instance size and type, OS type and test output.

Training tutorial:
Convergence graph for training tutorials
Performance metrics average_throughput, latency_p50, latency_p99 and MFU% if available

Please make sure this PR contains correct classification terms (Alpha, Beta, and Stable).

If possible, provide your results or a link to them for the reviewer to check your work.

Issue #, sim, or t.corp if available:

Link to RTD for my changes:
https://awsdocs-neuron-staging.readthedocs-hosted.com/en/YOUR_BRANCH_NAME/

Additional context:

PR Checklist

  • I've completely filled out the form above!
  • (If applicable) I've automated a test to safegaurd my changes from regression.
  • (If applicable) I've posted test collateral to prove my change was effective and not harmful.
  • (If applicable) I've added someone from QA to the list of reviewers. Do this if you didn't make an automated test or feel it's appropriate for another reason.
  • (If applicable) I've reviewed the licenses of updated and new binaries and their dependencies to make sure all licenses are on the pre-approved Amazon license list. See https://inside.amazon.com/en/services/legal/us/OpenSource/Pages/BlessedOpenSourceLicenses.aspx.

Pytest Marker Checklist

(Coming soon...)

Reviewer Checklist

  • For reviewer, before merging, please cross-check:
  • I've verified the changes render correctly on RTD (link above)
  • I've ensured the submitter completed the form
  • (If appropriate) I've run tests to verify the contents of the change

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@bryantbiggs
Copy link
Contributor Author

@aws-maens / @rgrandhiamzn any updates? we'd like to encourage users to use the official chart and not the dated manifests from a sample repo, thank you!

@bryantbiggs
Copy link
Contributor Author

FYI - the EKS docs have now been updated to reflect this change:

image

@bryantbiggs
Copy link
Contributor Author

@jeffhataws any update on merging this so we can remove the dependency on the samples repo?

Copy link
Contributor

@geetasg geetasg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. cc @mounchin @arjraman - we should update this to use our helm chart as well.

@delongmeng-aws delongmeng-aws merged commit 1b6c798 into aws-neuron:master Nov 6, 2024
@bryantbiggs bryantbiggs deleted the chore/update-k8s-efa-install branch November 6, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants