fix(rdma): stop setting FI_ORDER_NONE (aws#621)

FI_ORDER_NONE (defined as 0) is deprecated. Prefer to just leave it unset to avoid deprecation warnings when building against newer libfabric. This should be zeroed out when hints are constructed, anyway, so this buys us compatibility with libfabric-git without any change in behavior. Signed-off-by: Nicholas Sielicki <[email protected]>
aws-ofiwg-bot · Oct 4, 2024 · d49b8a0 · d49b8a0
1 parent fd290fb
commit d49b8a0
Showing 1 changed file with 0 additions and 3 deletions.
diff --git a/src/nccl_ofi_rdma.c b/src/nccl_ofi_rdma.c
@@ -7100,9 +7100,6 @@ static void get_hints(struct fi_info *hints)
 
 	hints->mode = 0;
 
-	hints->tx_attr->msg_order = FI_ORDER_NONE;
-	hints->rx_attr->msg_order = FI_ORDER_NONE;
-
 	hints->ep_attr->type = FI_EP_RDM;
 
 	hints->domain_attr->mr_mode = FI_MR_LOCAL | FI_MR_HMEM | FI_MR_VIRT_ADDR |