fix: handle duplicate keys in logger state to prevent ArgumentException #961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces ToDictionary() with manual dictionary population to handle duplicate keys that can occur with HTTP headers (e.g., multiple Content-Type headers). The last value wins for duplicate keys, maintaining existing behavior. Performance improvements: - O(n) complexity instead of O(n log n) from GroupBy - Single pass enumeration - No LINQ overhead or intermediate collections Fixes issue where curl requests with duplicate headers caused: "An item with the same key has already been added. Key: Content-Type" Adds test case for duplicate key scenarios.
pull-request-size
bot
added
the
size/M
github-actions
bot
added
the
bug
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #961 +/- ##
===========================================
+ Coverage 77.39% 77.45% +0.06%
===========================================
Files 271 271
Lines 10874 10886 +12
Branches 1282 1284 +2
===========================================
+ Hits 8416 8432 +16
Misses 2041 2041
+ Partials 417 413 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #956
Summary
Changes
Fixes issue where requests with duplicate headers caused:
"An item with the same key has already been added. Key: Content-Type"
Replaces ToDictionary() with manual dictionary population to handle duplicate keys that can occur with HTTP headers (e.g., multiple Content-Type headers).
The last value wins for duplicate keys, maintaining existing behavior.
ToDictionary()with manual dictionary population using indexer assignmentAdded test case
Log_WhenDuplicateKeysInState_LastValueWins()that verifies:User experience
Checklist
Please leave checklist items unchecked if they do not apply to your change.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.