Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): GovCloud Layer Workflow #5261

Merged
merged 12 commits into from
Oct 11, 2024
Merged

feat(ci): GovCloud Layer Workflow #5261

merged 12 commits into from
Oct 11, 2024

Conversation

sthulb
Copy link
Contributor

@sthulb sthulb commented Sep 27, 2024

Issue number: #1166

Summary

Changes

This PR aims to extend the availability of the AWS Lambda Powertools layer to AWS GovCloud regions.

User experience

Before this PR:

  • The Lambda Powertools layer is currently not published to AWS GovCloud regions.
  • GovCloud users have to manually copy the layer to their accounts as a workaround.

After this PR:

  • Include the following GovCloud regions in our layer publication process:
    • us-gov-east-1
    • us-gov-west-1

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

Signed-off-by: Simon Thulbourn <[email protected]>
@sthulb sthulb requested a review from a team as a code owner September 27, 2024 10:22
@boring-cyborg boring-cyborg bot added the github-actions Pull requests that update Github_actions code label Sep 27, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 27, 2024
@github-actions github-actions bot added the feature New feature or functionality label Sep 27, 2024
@leandrodamascena leandrodamascena linked an issue Sep 27, 2024 that may be closed by this pull request
.github/workflows/layer_govcloud.yml Show resolved Hide resolved
Copy link
Contributor

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sthulb! Thanks for working on this! I've left some comments to make this pipeline even safer and avoid any issues that could cause incidents in production.

Please consider the same comments for both regions.

.github/workflows/layer_govcloud.yml Outdated Show resolved Hide resolved
.github/workflows/layer_govcloud.yml Show resolved Hide resolved
.github/workflows/layer_govcloud.yml Show resolved Hide resolved
.github/workflows/layer_govcloud.yml Outdated Show resolved Hide resolved
.github/workflows/layer_govcloud.yml Show resolved Hide resolved
.github/workflows/layer_govcloud.yml Outdated Show resolved Hide resolved
.github/workflows/layer_govcloud.yml Show resolved Hide resolved
.github/workflows/layer_govcloud.yml Outdated Show resolved Hide resolved
.github/workflows/layer_govcloud.yml Show resolved Hide resolved
@sthulb sthulb marked this pull request as draft September 27, 2024 16:40
@sthulb sthulb marked this pull request as ready for review October 3, 2024 08:50
Copy link

@sthulb sthulb merged commit 97221af into develop Oct 11, 2024
6 checks passed
@sthulb sthulb deleted the feat/govcloud branch October 11, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or functionality github-actions Pull requests that update Github_actions code size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish layer to Gov Cloud regions
3 participants