-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(openapi): Allow values of any type in the examples of the Schema Object. #5575
Conversation
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @tonsho! Thank you so much for this PR, you were super quick!
I just left a quick comment before we merge this.
tests/functional/event_handler/_pydantic/test_openapi_params.py
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5575 +/- ##
========================================
Coverage 96.16% 96.16%
========================================
Files 229 229
Lines 10836 10836
Branches 2015 2015
========================================
Hits 10420 10420
Misses 327 327
Partials 89 89 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
6424392
to
372b7d2
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this and reporting a new error @tonsho!
APPROVED!
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
Issue number: #5573
Summary
Changes
Allow values of any type in the examples of the Schema Object.
User experience
Enable proper definition of examples in the Schema Object.
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.