Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): replace closed-issue-message action with powertools action #5641

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

dreamorosi
Copy link
Contributor

Issue number: closes #5636

Summary

Changes

Please provide a summary of what's being changed

This PR updates the workflow that runs when an issue is closed to use an action from our own shared repository (aws-powertools/actions) rather than a 3rd party one.

The new action uses the gh CLI to perform the action rather than a custom script.

User experience

Please share what the user experience looks like before and after this change

You can see the action in action here

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi self-assigned this Nov 25, 2024
@dreamorosi dreamorosi requested a review from a team as a code owner November 25, 2024 19:02
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 25, 2024
@boring-cyborg boring-cyborg bot added the github-actions Pull requests that update Github_actions code label Nov 25, 2024
@github-actions github-actions bot added the internal Maintenance changes label Nov 25, 2024
@leandrodamascena leandrodamascena changed the title chore: replace closed-issue-message action chore(ci): replace closed-issue-message action Nov 26, 2024
@leandrodamascena leandrodamascena changed the title chore(ci): replace closed-issue-message action chore(ci): replace closed-issue-message action with powertools action Nov 26, 2024
Copy link
Contributor

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @dreamorosi! APPROVED

@leandrodamascena leandrodamascena merged commit 2f4a841 into develop Nov 26, 2024
14 checks passed
@leandrodamascena leandrodamascena deleted the chore/update-close-issue branch November 26, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github-actions Pull requests that update Github_actions code internal Maintenance changes size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: Bug when using the action aws-actions/closed-issue-message
2 participants