fix(parameters): fix _transform_and_cache_get_parameters_response #7083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/M
ericbn
force-pushed
the
fix_transform_and_cache_get_parameters_response
branch
from
7272999 to
aaf9707
Compare
was passing positional arguments to transform_value in the wrong order,
making the latter fail miserably with
TransformParameterError: Unable to transform value using "the value"
because value was being passed as the expected transform argument.
Use keyword arguments instead and cover this with a test.
ericbn
force-pushed
the
fix_transform_and_cache_get_parameters_response
branch
from
aaf9707 to
81f598e
Compare
ericbn
commented
Aug 1, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7083 +/- ##
===========================================
+ Coverage 96.34% 96.35% +0.01%
===========================================
Files 275 275
Lines 12980 12980
Branches 965 965
===========================================
+ Hits 12505 12507 +2
+ Misses 367 366 -1
+ Partials 108 107 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
leandrodamascena
requested review from
leandrodamascena
and removed request for
anafalcao
|
Oi @leandrodamascena. Sempre um prazer quando surge uma oportunidade pra contribuir mais um pouco de volta! I've commented on #7084. Let me know if you need more context there. |
|
leandrodamascena
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #7084
Summary
Changes
_transform_and_cache_get_parameters_responsewas passing positional arguments totransform_valuein the wrong order, making the latter fail miserably withbecause
valuewas being passed as the expectedtransformargument. Use keyword arguments instead and cover this with a test.User experience
get_parameters_by_namefails when used withtransform. It's surprising that I might the first one trying to use this. 😅Example:
Fails with:
aws_lambda_powertools.utilities.parameters.exceptions.TransformParameterError: Unable to transform value using '"value of /dev/param2"' transform: 'NoneType' object is not callableChecklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.