Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: Bug when using the action aws-actions/closed-issue-message #3353

Closed
2 tasks done
leandrodamascena opened this issue Nov 24, 2024 · 5 comments · Fixed by #3364
Closed
2 tasks done

Maintenance: Bug when using the action aws-actions/closed-issue-message #3353

leandrodamascena opened this issue Nov 24, 2024 · 5 comments · Fixed by #3364
Assignees
Labels
automation This item relates to automation completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)

Comments

@leandrodamascena
Copy link
Contributor

leandrodamascena commented Nov 24, 2024

Summary

3 days ago, dependabot opened an issue to bump the version of the closed-issue-message action, but since then our actions are failing with the following error:

https://github.com/aws-powertools/powertools-lambda-typescript/actions/runs/11975020182/job/33387427047

Run aws-actions/closed-issue-message@37548691e7cc75ba58f85c9f873f9eee43590449
/usr/bin/docker run --name c70d2851342b74a546b4a61c96dffc299f21_a8c2b1 --label 35c70d --workdir /github/workspace --rm -e "INPUT_REPO-TOKEN" -e "INPUT_MESSAGE" -e "HOME" -e "GITHUB_JOB" -e "GITHUB_REF" -e "GITHUB_SHA" -e "GITHUB_REPOSITORY" -e "GITHUB_REPOSITORY_OWNER" -e "GITHUB_REPOSITORY_OWNER_ID" -e "GITHUB_RUN_ID" -e "GITHUB_RUN_NUMBER" -e "GITHUB_RETENTION_DAYS" -e "GITHUB_RUN_ATTEMPT" -e "GITHUB_REPOSITORY_ID" -e "GITHUB_ACTOR_ID" -e "GITHUB_ACTOR" -e "GITHUB_TRIGGERING_ACTOR" -e "GITHUB_WORKFLOW" -e "GITHUB_HEAD_REF" -e "GITHUB_BASE_REF" -e "GITHUB_EVENT_NAME" -e "GITHUB_SERVER_URL" -e "GITHUB_API_URL" -e "GITHUB_GRAPHQL_URL" -e "GITHUB_REF_NAME" -e "GITHUB_REF_PROTECTED" -e "GITHUB_REF_TYPE" -e "GITHUB_WORKFLOW_REF" -e "GITHUB_WORKFLOW_SHA" -e "GITHUB_WORKSPACE" -e "GITHUB_ACTION" -e "GITHUB_EVENT_PATH" -e "GITHUB_ACTION_REPOSITORY" -e "GITHUB_ACTION_REF" -e "GITHUB_PATH" -e "GITHUB_ENV" -e "GITHUB_STEP_SUMMARY" -e "GITHUB_STATE" -e "GITHUB_OUTPUT" -e "RUNNER_OS" -e "RUNNER_ARCH" -e "RUNNER_NAME" -e "RUNNER_ENVIRONMENT" -e "RUNNER_TOOL_CACHE" -e "RUNNER_TEMP" -e "RUNNER_WORKSPACE" -e "ACTIONS_RUNTIME_URL" -e "ACTIONS_RUNTIME_TOKEN" -e "ACTIONS_CACHE_URL" -e "ACTIONS_RESULTS_URL" -e GITHUB_ACTIONS=true -e CI=true -v "/var/run/docker.sock":"/var/run/docker.sock" -v "/home/runner/work/_temp/_github_home":"/github/home" -v "/home/runner/work/_temp/_github_workflow":"/github/workflow" -v "/home/runner/work/_temp/_runner_file_commands":"/github/file_commands" -v "/home/runner/work/powertools-lambda-python/powertools-lambda-python":"/github/workspace" 35c70d:2851342b74a546b4a61c96dffc299f21
/node_modules/undici/lib/handler/RetryHandler.js:29
    } = retryOptions ?? {}

Why is this needed?

We need this to add comments in closed issues/PR.

Which area does this relate to?

Automation

Solution

They need to fix this issue: aws-actions/closed-issue-message#13

Acknowledgment

Future readers

Please react with 👍 and your use case to help us understand customer demand.

@leandrodamascena leandrodamascena added internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) triage This item has not been triaged by a maintainer, please wait labels Nov 24, 2024
@dreamorosi
Copy link
Contributor

Gonna remove the action, we can do the same thing in a couple lines since Octokit is already installed in the action environment.

@dreamorosi dreamorosi added automation This item relates to automation confirmed The scope is clear, ready for implementation and removed triage This item has not been triaged by a maintainer, please wait labels Nov 25, 2024
@dreamorosi dreamorosi self-assigned this Nov 25, 2024
@dreamorosi dreamorosi moved this from Triage to Backlog in Powertools for AWS Lambda (TypeScript) Nov 25, 2024
@leandrodamascena
Copy link
Contributor Author

Hey @dreamorosi! Yeah, lets remove this action.

Can you please work on this in TS repository and then I replicate to Python?

Thanks

@dreamorosi
Copy link
Contributor

dreamorosi commented Nov 25, 2024

I opened a PR to replace the action with our own version.

The new version lives in the aws-powertools/actions repo and is a one-liner that uses the gh CLI to leave a comment.

Once the PR is merged, I can open one in the Python repo and update the action link - the inputs and signature remain the same.

@dreamorosi dreamorosi moved this from Backlog to Pending review in Powertools for AWS Lambda (TypeScript) Nov 25, 2024
@github-project-automation github-project-automation bot moved this from Pending review to Coming soon in Powertools for AWS Lambda (TypeScript) Nov 25, 2024
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added pending-release This item has been merged and will be released soon and removed confirmed The scope is clear, ready for implementation labels Nov 25, 2024
Copy link
Contributor

This is now released under v2.12.0 version!

@github-actions github-actions bot added completed This item is complete and has been merged/shipped and removed pending-release This item has been merged and will be released soon labels Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Projects
Status: Coming soon
Development

Successfully merging a pull request may close this issue.

2 participants