chore(maintenance): switch to unmanaged log group for functions #3014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreamorosi
force-pushed
the
chore/e2e_fn_loggroup
branch
from
c9d9013 to
3259b95
Compare
|
Blocked by #3012 |
dreamorosi
added
blocked
pull-request-size
bot
added
size/M
pull-request-size
bot
added
size/S
|
|
Integration tests passing: https://github.com/aws-powertools/powertools-lambda-typescript/actions/runs/10788810733 |
leandrodamascena
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
This PR updates the base
TestNodejsFunctionCDK construct so that it now creates and manages its own Amazon CloudWatchLogGroupresource.With this change we can now set the retention policy directly on the group itself which removes the need of using the
logRetentionproperty on theNodejsFunctionconstruct. A nice side effect of this removal is that CDK no longer has to create a custom resource to update the log retention after the fact, thus reducing the number of resources deployed for each test.Issue number: closes #3013
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.