Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(maintenance): switch layers to vitest #3292

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Conversation

dreamorosi
Copy link
Contributor

Summary

Changes

Please provide a summary of what's being changed

This PR moves the unit and end to end tests for the layers package to use vitest as test runner.

This action is part of the ongoing migration from Jest to Vitest, and all the changes in the tests focus on changing the imports and using Vitest-specific APIs and rewording the test headers.

The PR includes a minor change to the TestInvocationLogs.doesAnyFunctionLogsContains() method which now accepts regexes as well as strings for the needle to find in the haystack. This simplifies slightly the tests for the layers while maintaining backwards compatibility.

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number: closes #3291


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi self-assigned this Nov 5, 2024
@dreamorosi dreamorosi requested review from a team as code owners November 5, 2024 15:05
@boring-cyborg boring-cyborg bot added dependencies Changes that touch dependencies, e.g. Dependabot, etc. tests PRs that add or change tests labels Nov 5, 2024
@pull-request-size pull-request-size bot added the size/L PRs between 100-499 LOC label Nov 5, 2024
Copy link

sonarqubecloud bot commented Nov 5, 2024

Copy link
Contributor

@am29d am29d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR, only few left to finally switch to vitest!

@am29d am29d merged commit e922699 into main Nov 5, 2024
55 checks passed
@am29d am29d deleted the chore/layers_vitest branch November 5, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Changes that touch dependencies, e.g. Dependabot, etc. size/L PRs between 100-499 LOC tests PRs that add or change tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: migrate test runner to vitest for layers package
2 participants