fix(parser): parse sqs record body field as JSON and S3Schema in S3SqsEventNoificationRecordSchema #3529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
parser
|
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
github-actions
bot
added
the
feature
…icationRecordSchema
cyrildewit
force-pushed
the
feature/issue-3525-parse-json-stringified-body-field-of-S3SqsEventNotificationRecordSchema
branch
from
ffa115a to
188d7fb
Compare
cyrildewit
changed the title
…dy-field-of-S3SqsEventNotificationRecordSchema
|
dreamorosi
approved these changes
Feb 1, 2025
|
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request alters the Zod schema
S3SqsEventNoificationRecordSchemato automatically parse the JSON encoded S3 event (S3Schema) within the "body" field of an SQS record. This makes sure that the S3 event payload is validated against theS3Schemaand it allows us to immediately work with a typed evennt object.The idea was initially raised/discussed in this discussion #3449 and was later converted into a feature request #3525. More context can be found there.
Changes
S3Schemawith theJSONStringifiedhelper in thebodyfield ofS3SqsEventNotificationRecordSchemaIssue number: #3525
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.