Skip to content

Commit

Permalink
Merge pull request #22 from trevorrobertsjr/update-flask-cors
Browse files Browse the repository at this point in the history
Updated flask-cors to address Issue #21
  • Loading branch information
MitchyBAwesome authored Jul 8, 2020
2 parents 0965ede + 247f4ce commit f0e047d
Show file tree
Hide file tree
Showing 9 changed files with 17 additions and 17 deletions.
2 changes: 1 addition & 1 deletion workshop-1/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ The Mythical Mysfits adoption agency infrastructure has always been running dire
---> f24fe4e69d88
Step 7/10 : RUN pip install -r ./requirements.txt
---> Running in 1c878073d631
Collecting Flask==0.12.2 (from -r ./requirements.txt (line 1))
Collecting Flask==0.12.5 (from -r ./requirements.txt (line 1))
</pre>

Try reordering the instructions in your Dockerfile to copy the monolith code over after the requirements are installed. The thinking here is that the Python source will see more changes than the dependencies noted in requirements.txt, so why rebuild requirements every time when we can just have it be another cached layer.
Expand Down
4 changes: 2 additions & 2 deletions workshop-1/app/like-service/service/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Flask==0.12.2
flask-cors==3.0.0
Flask==0.12.5
flask-cors==3.0.8
requests==1.2.3
4 changes: 2 additions & 2 deletions workshop-1/app/monolith-service/service/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Flask==0.12.2
flask-cors==3.0.0
Flask==0.12.5
flask-cors==3.0.8
boto3==1.7.16
4 changes: 2 additions & 2 deletions workshop-2/app/like-service/service/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Flask==0.12.2
flask-cors==3.0.0
Flask==0.12.5
flask-cors==3.0.8
requests==1.2.3
4 changes: 2 additions & 2 deletions workshop-2/app/monolith-service/service/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Flask==0.12.2
flask-cors==3.0.0
Flask==0.12.5
flask-cors==3.0.8
boto3==1.7.16
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Flask==0.12.2
flask-cors==3.0.0
Flask==0.12.5
flask-cors==3.0.8
requests==1.2.3
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Flask==0.12.2
flask-cors==3.0.0
Flask==0.12.5
flask-cors==3.0.8
boto3==1.7.16
4 changes: 2 additions & 2 deletions workshop-3/app/like-service/service/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Flask==0.12.2
flask-cors==3.0.0
Flask==0.12.5
flask-cors==3.0.8
requests==1.2.3
4 changes: 2 additions & 2 deletions workshop-3/app/monolith-service/service/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Flask==0.12.2
flask-cors==3.0.0
Flask==0.12.5
flask-cors==3.0.8
boto3==1.7.16

0 comments on commit f0e047d

Please sign in to comment.