Amazon ElastiCache | Build a generative AI Virtual Assistant with Ama… #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…zon Bedrock | dotenv file
…zon Bedrock | dotenv file
LakshmiPeri23
requested changes
Aug 1, 2024
There was a problem hiding this comment.
The langchain imports in the lib are old from 2023 and modules used here for memory , conversation summary , llm , embeddings have all been migrated from langchain to langchain-community / langchain-core / langchain-aws.
- ConverseAPI helps simplify integration and would be a good alternative.
- The implementation of chat history class defined in this version does not work well with LCEL chaining recommendation from langchain.
- Need to re-visit the chat history implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…zon Bedrock
Issue #, if available:
Description of changes:
Amazon ElastiCache | Build a generative AI Virtual Assistant with Amazon Bedrock
requirements.txtto narrow down the list of packages and created arequirements.lockfor all packageschatbot_app.pyandchatbot_lib.pyfiles to usedotenvpackage and enhance readability and docstrings.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.