Fix BabylonJS version conflict #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The specified BabylonJS version dependency for the
demos-babylonpackage didn't match the version specified by theamazon-sumerian-hosts-babylonpackage. This could cause the demos to break under certain conditions. It could also mislead users into trying to use Hosts with an incompatible (newer) version of BabylonJS. This PR addresses the mismatch and makes it clear to users that Hosts are currently only compatible with BabylonJS v4 and should not be used with BabylonJS v5.Related Issue #
Issue 154
Reviewer Testing Instructions
Follow the regular steps for running the BabylonJS demos.
Submission Checklist
I confirm that I have...
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.