Fix missing babylon types #190
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e them manually when we need to
* fix-broken-webpack-dependency: pin webpack dependency versions so they won't break, and we can update them manually when we need to
…having Webpack provide it, and instead import it as a regular JavaScript module (note that Three.js has deprecated the global and will provide only JavaScript modules at version 0.160)
…bit different than other libs, and we should allow people to try newer versions, while if something breaks we can claim that it at least works with 0.127.0
…ettier, use eslint only for non-formatting rules
… AWS from 'aws-sdk'`, fix three.texttospeech.html test
…o need for `exports` unless multiple paths need configuring, or CommonJS support is needed, but we're no longer explicitly supporting CommonJS modules, and CommonJS users can use the `import()` function to import the lib, and they can even use the `deasync` package if they really really want the import to be "synchronous", so there's really no need to hold onto the past and we can make moving forward as simple and standards-based as possible)
…st CDN link to aws-sdk and use the local version, and update docs as needed for the new ESM format without a required build
…properly appear within the Babylon host code
trusktr
force-pushed
the
fix-missing-babylon-types
branch
from
b7eb17a to
f6a20f0
Compare
This was referenced Feb 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This is branched off of the branch for
See that PR first. For convenience, here's the diff between the branches, as the
Files changedtab will not be useful.Description
Babylone.js types were not visible within the Babylon host code.
Before:
After:
Related Issue #
Reviewer Testing Instructions
Run
npm install && npm run compile-tsat the root of the repo. Then openpackages/amazon-sumerian-hosts-babylon/src/Babylon.js/HostObject.jsand hover on Babylon APIs and you will see helpful tooltips showing types.Submission Checklist
I confirm that I have...
This contribution is licensed under the original MIT-0 license of the repository. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.