Updates with working version of code #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue , if available:
Description of changes:
*Issue #16
terraform get
README.md steps mentions the use of “terraform get” which is no more in use
- Tags argument usage
Usage of tags argument is incorrect, as the latest versions of terraform use an equals sign to assign values.
Error: Unsupported block type
│
│ on site/pub_priv_vpc.tf line 14, in resource "aws_vpc" "default":
│ 14: tags {
│
│ Blocks of type "tags" are not expected here. Did you mean to define argument "tags"? If so, use the equals sign to assign it a value.
The same errors occurs in :
site/webapp-sg.tf
site/nat-sg.tf
site/bastion-sg.tf
load_balancers/webapp-elb.tf
wait_for_elb_capacity usage is incorrect
Usage of wait_for_elb_capacity property in aws_autoscaling_group resource is incorrect.
Error: Incorrect attribute value type
│
│ on autoscaling_groups/webapp-asg.tf line 17, in resource "aws_autoscaling_group" "webapp_asg":
│ 17: wait_for_elb_capacity = false
│
│ Inappropriate value for attribute "wait_for_elb_capacity": number required.
Variables can be referenced without double quotes
All variables are referenced using ${} which is no longer needed.
Terraform destroy issue resolved
In the README step of destroying resources via Terraform, it has been mentioned due to this GitHub Issue, create_before_destroy lifecycle policy has to be manually changed to false in autoscaling_groups/webapp-asg.tf and launch_configurations/webapp-lc.tf files. Now this GitHub Issue seems to be closed, so recommended to test if the resources are destroyed via Terraform without this manual change.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.