Refactor workshop to make deployment simpler #316
+4,357
−890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
added @allamand and @hmuthusamy for review as they had a lot of changes as well. |
hmuthusamy
reviewed
Oct 1, 2025
| name: keycloak-config | ||
| creationPolicy: Owner | ||
| deletionPolicy: Retain | ||
| deletionPolicy: Retain |
There was a problem hiding this comment.
Do we need to keep the secret after the external secret is deleted?
There was a problem hiding this comment.
It was being retained in riv25, so did not change it but if we agree that it should be removed, we can change the deletionPolicy
hmuthusamy
reviewed
Oct 1, 2025
allamand
reviewed
Oct 1, 2025
| # tenant: tenant1 | ||
| # fleet_member: dev | ||
| # #TODO I think this is not used here, but already stored in the secret | ||
| # enable_cert_manager: "true" |
There was a problem hiding this comment.
Ok so this file is enabled by default now. How we defines the addons to install on spoke cluster ?
There was a problem hiding this comment.
Now generating this file during init. However, enabling the addon comes from spoke cluster secret directly. The values in secret are managed from platform/infra/terraform/hub-config.yaml
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
punkwalker
force-pushed
the
refactor-workshop
branch
from
e6dece5 to
a036abc
Compare
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
hmuthusamy
approved these changes
Oct 2, 2025
| # Backend configuration provided via CLI parameters | ||
| backend "s3" { | ||
| # bucket and provided via -backend-config | ||
| key = "gitlabinfra/terraform.tfstate" |
| # Store both hash and key in a single file to avoid regenerating on each run | ||
| locals { | ||
| # Update password_expiry for password and key rotation | ||
| password_expiry = "2025-12-31" |
There was a problem hiding this comment.
can we make it indefinite post RIV?
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
Signed-off-by: Pankaj Walke <[email protected]>
punkwalker
force-pushed
the
refactor-workshop
branch
from
3bd6381 to
3537375
Compare
Signed-off-by: Pankaj Walke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Overview
This PR introduces a comprehensive refactoring of workshop infrastructure, focusing on improved deployment
automation, enhanced security configurations, and streamlined cluster management.
Key Changes
🏗️ Infrastructure Refactoring
• Separated cluster creation from bootstrap process for better modularity
• Added dedicated cluster deployment scripts (platform/infra/terraform/cluster/)
• Enhanced Terraform configuration with improved locals, variables, and provider management
• Consolidated GitLab infrastructure deployment with dedicated terraform module
🔧 Script Improvements
• Refactored deployment scripts with improved error handling and logging
• Added comprehensive utility functions (scripts/utils.sh, argocd-utils.sh, backstage-utils.sh)
• Enhanced initialization process with 0-init.sh and improved URL generation
🔐 Security & Authentication
• Enhanced Keycloak configuration with improved client management and role assignments
• Improved external secrets management with better secret store configurations
• Added pod identity management with comprehensive IAM role configurations
• Enhanced ArgoCD security with PKCE configuration and improved secret handling
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.