Skip to content

Make default value for pControlTowerRegionsOnly consistent #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make default value for pControlTowerRegionsOnly consistent #314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion aws_sra_examples/easy_setup/templates/sra-easy-setup.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1177,7 +1177,7 @@ Parameters:
Type: String
pGuardDutyCustomerGovernedRegionsOnly:
AllowedValues: ["true", "false"]
Default: "false"
Default: "true"
Description: Indicates whether to enable GuardDuty in the customer's Goverened Regions only. Example - Control Tower regions, or Common Prerequisites regions.
Type: String
pGuardDutyEnabledRegions:
Expand Down
4 changes: 2 additions & 2 deletions aws_sra_examples/modules/guardduty-org-module/templates/sra-guardduty-org-module-main.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,8 +271,8 @@ Parameters:
Type: String
pControlTowerRegionsOnly:
Type: String
Description: Only enable in the Control Tower governed regions (set to true for environments without AWS Control Tower)
Default: 'false'
Description: Only enable in the Control Tower governed regions (set to false for environments without AWS Control Tower)
Default: 'true'
AllowedValues: ['true', 'false']
pEnabledRegions:
AllowedPattern: '^$|^([a-z0-9-]{1,64})$|^(([a-z0-9-]{1,64},)*[a-z0-9-]{1,64})$'
Expand Down
4 changes: 2 additions & 2 deletions aws_sra_examples/modules/guardduty-org-module/templates/sra-guardduty-org-solution.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,8 +358,8 @@ Parameters:
Type: String
pControlTowerRegionsOnly:
Type: String
Description: Only enable in the Control Tower governed regions (set to true for environments without AWS Control Tower)
Default: 'false'
Description: Only enable in the Control Tower governed regions (set to false for environments without AWS Control Tower)
Default: 'true'
AllowedValues: ['true', 'false']
pEnabledRegions:
AllowedPattern: '^$|^([a-z0-9-]{1,64})$|^(([a-z0-9-]{1,64},)*[a-z0-9-]{1,64})$'
Expand Down
2 changes: 1 addition & 1 deletion aws_sra_examples/solutions/guardduty/guardduty_org/templates/sra-guardduty-org-main-ssm.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ Parameters:
pControlTowerRegionsOnly:
Type: String
Description: Only enable in the Control Tower governed regions (set to true for environments without AWS Control Tower)
Default: 'true' # TODO: best practice is to set this to false, however, there is a bug that prevents this from working
Default: 'true' # TODO: best practice is to set this to false, however, there is a bug (insert bug id) that prevents this from working
AllowedValues: ['true', 'false']
pCreateLambdaLogGroup:
AllowedValues: ['true', 'false']
Expand Down
2 changes: 1 addition & 1 deletion ...utions/security_lake/security_lake_org/templates/sra-security-lake-org-configuration.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ Parameters:
Default: 'ALL'
pControlTowerRegionsOnly:
AllowedValues: ['true', 'false']
Default: 'false'
Default: 'true'
Description: Only enable in the customer governed regions specified in Control Tower or Common Prerequisites solution
Type: String
pComplianceFrequency:
Expand Down