Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] torchtune usecase #260

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[WIP] torchtune usecase #260

wants to merge 1 commit into from

Conversation

pbelevich
Copy link
Collaborator

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@sean-smith sean-smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include a README file

@pbelevich
Copy link
Collaborator Author

Please include a README file

Of course, I marked it as "work in progress"

## For G4dn and other G5, comment out all
# export FI_EFA_USE_DEVICE_RDMA=1 # use for p4d
# export FI_EFA_FORK_SAFE=1
export FI_LOG_LEVEL=1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export FI_LOG_LEVEL=1
export FI_LOG_LEVEL=warn

###### User Variables #####
###########################

GPUS_PER_NODE=4 # 4 for G5.12x, 8 for P4/P5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
GPUS_PER_NODE=4 # 4 for G5.12x, 8 for P4/P5
GPUS_PER_NODE=8 # 4 for G5.12x, 8 for P4/P5

Copy link
Contributor

@mhuguesaws mhuguesaws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider moving to container.
Left comments

@KeitaW KeitaW force-pushed the torchtune branch 2 times, most recently from db51efe to 6002abb Compare June 4, 2024 02:26
@KeitaW KeitaW force-pushed the main branch 3 times, most recently from 44e448e to 1209815 Compare June 4, 2024 02:30
@KeitaW KeitaW closed this Aug 12, 2024
@KeitaW KeitaW reopened this Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants